Re: R: R: [PATCH 1/3] watchdog: qcom-wdt: add option to skip pretimeout

Guenter Roeck
2020-02-04T17:37:22Z

On Tue, Feb 04, 2020 at 06:30:40PM +0100, ansuelsmth@gmail.com wrote:
> > On Tue, Feb 04, 2020 at 05:16:34PM +0100, ansuelsmth@gmail.com wrote:
> > > If something like this is used, msm-timer require interrupts. Without
> this
> > > configuration, the device is unbootable as the system froze on system
> > > bootup.
> > >
> > > timer@200a000 {
> > > compatible = "qcom,kpss-timer", "qcom,msm-timer";
> > > interrupts = <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>,
> > > <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>,
> > > <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>,
> > > <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>,
> > > <GIC_PPI 5 (GIC_CPU_MASK_SIMPLE(2) |
> > > IRQ_TYPE_EDGE_RISING)>;
> > > no-pretimeout;
> > > reg = <0x0200a000 0x100>;
> > > clock-frequency = <25000000>,
> > > <32768>;
> > > clocks = <&sleep_clk>;
> > > clock-names = "sleep";
> > > cpu-offset = <0x80000>;
> > > };
> > >
> >
> > I think this is all wrong; the new property shows up in a node which
> > is completely unrelated to a watchdog. Maybe it wasn't such a good idea
> > to tie the watchdog to the timer node. At the very least, the situation
> > should be handled in the driver via of_table flags. If the situation can't
> > be handled that way, something is even more wrong. In that case it might
> > be better to revert commit 36375491a439 until that is sorted out properly.
> >
> > Guenter
> >
>
> So pretimeout should be enabled only for kpss-wdt and disabled with a flag
> in the of_table of the driver?
>

Correct, if that is the determining factor.

Guenter