* [PATCH] mfd: constify properties in mfd_cell
@ 2020-02-04 20:16 Tomas Winkler
2020-02-04 21:22 ` Andy Shevchenko
2020-02-04 22:48 ` Greg Kroah-Hartman
0 siblings, 2 replies; 4+ messages in thread
From: Tomas Winkler @ 2020-02-04 20:16 UTC (permalink / raw)
To: Lee Jones, Andy Shevchenko, Greg Kroah-Hartman
Cc: linux-kernel, Tomas Winkler
Constify 'struct property_entry *properties' in
mfd_cell and platform_device. It is always passed
around as a pointer const struct.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
include/linux/mfd/core.h | 2 +-
include/linux/platform_device.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
index d01d1299e49d..7e5ac3c00891 100644
--- a/include/linux/mfd/core.h
+++ b/include/linux/mfd/core.h
@@ -70,7 +70,7 @@ struct mfd_cell {
size_t pdata_size;
/* device properties passed to the sub devices drivers */
- struct property_entry *properties;
+ const struct property_entry *properties;
/*
* Device Tree compatible string
diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
index 276a03c24691..8e83c6ff140d 100644
--- a/include/linux/platform_device.h
+++ b/include/linux/platform_device.h
@@ -89,7 +89,7 @@ struct platform_device_info {
size_t size_data;
u64 dma_mask;
- struct property_entry *properties;
+ const struct property_entry *properties;
};
extern struct platform_device *platform_device_register_full(
const struct platform_device_info *pdevinfo);
--
2.21.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mfd: constify properties in mfd_cell
2020-02-04 20:16 [PATCH] mfd: constify properties in mfd_cell Tomas Winkler
@ 2020-02-04 21:22 ` Andy Shevchenko
2020-02-04 21:33 ` Winkler, Tomas
2020-02-04 22:48 ` Greg Kroah-Hartman
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-02-04 21:22 UTC (permalink / raw)
To: Tomas Winkler
Cc: Lee Jones, Andy Shevchenko, Greg Kroah-Hartman,
Linux Kernel Mailing List
On Tue, Feb 4, 2020 at 10:18 PM Tomas Winkler <tomas.winkler@intel.com> wrote:
>
> Constify 'struct property_entry *properties' in
> mfd_cell and platform_device. It is always passed
> around as a pointer const struct.
>
After
commit 277036f05be242540b7bfe75f226107d04f51b06
Author: Jan Kiszka <jan.kiszka@siemens.com>
Date: Fri Jun 2 07:43:27 2017 +0200
platform: Accept const properties
this one makes sense.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Does intel-lpss* compile with this change?
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> include/linux/mfd/core.h | 2 +-
> include/linux/platform_device.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index d01d1299e49d..7e5ac3c00891 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -70,7 +70,7 @@ struct mfd_cell {
> size_t pdata_size;
>
> /* device properties passed to the sub devices drivers */
> - struct property_entry *properties;
> + const struct property_entry *properties;
>
> /*
> * Device Tree compatible string
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 276a03c24691..8e83c6ff140d 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -89,7 +89,7 @@ struct platform_device_info {
> size_t size_data;
> u64 dma_mask;
>
> - struct property_entry *properties;
> + const struct property_entry *properties;
> };
> extern struct platform_device *platform_device_register_full(
> const struct platform_device_info *pdevinfo);
> --
> 2.21.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] mfd: constify properties in mfd_cell
2020-02-04 21:22 ` Andy Shevchenko
@ 2020-02-04 21:33 ` Winkler, Tomas
0 siblings, 0 replies; 4+ messages in thread
From: Winkler, Tomas @ 2020-02-04 21:33 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Lee Jones, Andy Shevchenko, Greg Kroah-Hartman,
Linux Kernel Mailing List
>
> On Tue, Feb 4, 2020 at 10:18 PM Tomas Winkler <tomas.winkler@intel.com>
> wrote:
> >
> > Constify 'struct property_entry *properties' in mfd_cell and
> > platform_device. It is always passed around as a pointer const struct.
> >
>
> After
>
> commit 277036f05be242540b7bfe75f226107d04f51b06
> Author: Jan Kiszka <jan.kiszka@siemens.com>
> Date: Fri Jun 2 07:43:27 2017 +0200
>
> platform: Accept const properties
>
> this one makes sense.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Does intel-lpss* compile with this change?
Yes, It does.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: constify properties in mfd_cell
2020-02-04 20:16 [PATCH] mfd: constify properties in mfd_cell Tomas Winkler
2020-02-04 21:22 ` Andy Shevchenko
@ 2020-02-04 22:48 ` Greg Kroah-Hartman
1 sibling, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2020-02-04 22:48 UTC (permalink / raw)
To: Tomas Winkler; +Cc: Lee Jones, Andy Shevchenko, linux-kernel
On Tue, Feb 04, 2020 at 10:16:51PM +0200, Tomas Winkler wrote:
> Constify 'struct property_entry *properties' in
> mfd_cell and platform_device. It is always passed
> around as a pointer const struct.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> include/linux/mfd/core.h | 2 +-
> include/linux/platform_device.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index d01d1299e49d..7e5ac3c00891 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -70,7 +70,7 @@ struct mfd_cell {
> size_t pdata_size;
>
> /* device properties passed to the sub devices drivers */
> - struct property_entry *properties;
> + const struct property_entry *properties;
>
> /*
> * Device Tree compatible string
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 276a03c24691..8e83c6ff140d 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -89,7 +89,7 @@ struct platform_device_info {
> size_t size_data;
> u64 dma_mask;
>
> - struct property_entry *properties;
> + const struct property_entry *properties;
> };
> extern struct platform_device *platform_device_register_full(
> const struct platform_device_info *pdevinfo);
> --
> 2.21.1
>
This really is two different patches, can you split and resend?
thanks,
gre gk-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-04 22:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-04 20:16 [PATCH] mfd: constify properties in mfd_cell Tomas Winkler
2020-02-04 21:22 ` Andy Shevchenko
2020-02-04 21:33 ` Winkler, Tomas
2020-02-04 22:48 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox