Re: [PATCH 2/2] staging: octeon-usb: delete the octeon usb host controller driver

Greg Kroah-Hartman
2019-12-11T07:42:22Z

On Tue, Dec 10, 2019 at 11:27:44PM +0200, Aaro Koskinen wrote:
> On Tue, Dec 10, 2019 at 09:19:57PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Dec 10, 2019 at 09:31:54PM +0200, Aaro Koskinen wrote:
> > > Hi,
> > >
> > > On Tue, Dec 10, 2019 at 10:15:09AM +0100, Greg Kroah-Hartman wrote:
> > > > This driver was merged back in 2013 and shows no progress toward every
> > > > being merged into the "correct" part of the kernel.
> > >
> > > Do you mean all the patches since 2013 were "no progress"? Thanks.
> >
> > I have not seen any proposals to get it out of staging at all. If the
> > only thing left really is just those two simple TODO lines, then why has
> > it taken 6 years to do that?
>
> Do you mean you did not see the below thread when I asked for help;
> it was a kind of propsal, no? Also things take time when you are just a
> hobbyist reverse engineering undocumented hardware that you also run in
> production. Yes, I'm slow, but the starting point wasn't also a very good.
>
> https://marc.info/?t=155839354700002&r=1&w=2

I have the short-term memory of a squirrel, remember I get 1000 emails a
day to deal with.

That thread was from back in May, the instructions on what was needed to
be done is quite simple, so there should not have been a multi-month
delay from then until now. What happened?

> I don't mind you deleting the driver, and if you think that "no progress"
> is true then I'm very sorry for all those commits/noise.

Don't be sorry, you have fixed it up to make it ready to be merged
properly. But yes, there is no progress being made now, so it should
either be dropped or merged properly.

If you don't have the time now to do it, that's fine, the revert to get
the code back just takes one single git command when you, or someone
else, can get the chance to do it.

Don't take it personally, this is about to happen to almost all of the
staging drivers that have been languishing around :)

thanks,

greg k-h