Re: [PATCH 1/2] staging: octeon: delete driver

Matthew Wilcox
2020-02-04T20:31:25Z

On Tue, Feb 04, 2020 at 08:06:14PM +0000, Chris Packham wrote:
> On Tue, 2020-02-04 at 07:09 +0000, gregkh@linuxfoundation.org wrote:
> > On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote:
> > > I'll pipe up on this thread too
> > >
> > > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote:
> > > > On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote:
> > > > > This driver has been in the tree since 2009 with no real movement to get
> > > > > it out. Now it is starting to cause build issues and other problems for
> > > > > people who want to fix coding style problems, but can not actually build
> > > > > it.
> > > > >
> > > > > As nothing is happening here, just delete the module entirely.
> > > > >
> > > > > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > > > > Cc: David Daney <ddaney@caviumnetworks.com>
> > > > > Cc: "David S. Miller" <davem@davemloft.net>
> > > > > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> > > > > Cc: Guenter Roeck <linux@roeck-us.net>
> > > > > Cc: YueHaibing <yuehaibing@huawei.com>
> > > > > Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> > > > > Cc: Wambui Karuga <wambui.karugax@gmail.com>
> > > > > Cc: Julia Lawall <julia.lawall@lip6.fr>
> > > > > Cc: Florian Westphal <fw@strlen.de>
> > > > > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > Cc: Branden Bonaby <brandonbonaby94@gmail.com>
> > > > > Cc: "Petr Štetiar" <ynezz@true.cz>
> > > > > Cc: Sandro Volery <sandro@volery.com>
> > > > > Cc: Paul Burton <paulburton@kernel.org>
> > > > > Cc: Dan Carpenter <dan.carpenter@oracle.com>
> > > > > Cc: Giovanni Gherdovich <bobdc9664@seznam.cz>
> > > > > Cc: Valery Ivanov <ivalery111@gmail.com>
> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > >
> > > > Acked-by: Guenter Roeck <linux@roeck-us.net>
> > >
> > > Please can we keep this driver. We do have platforms using it and we
> > > would like it to stay around.
> > >
> > > Clearly we'll need to sort things out to a point where they build
> > > successfully. We've been hoping to see this move out of staging ever
> > > since we selected Cavium as a vendor.
> >
> > Great, can you send me a patchset that reverts this and fixes the build
> > issues and accept maintainership of the code?
> >
>
> Yep will do.
>
> On Tue, 2020-02-04 at 10:21 +0300, Dan Carpenter wrote:
> > My advice is to delete all the COMPILE_TEST code. That stuff was a
> > constant source of confusion and headaches.
>
> I was also going to suggest this. Since the COMPILE_TEST has been a
> source of trouble I was going to propose dropping the || COMPILE_TEST
> from the Kconfig for the octeon drivers.

Not having it also causes problems. I didn't originally add it for
shits and giggles.