From: Jean Delvare <jdelvare@suse.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
Paul Burton <paulburton@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
Huacai Chen <chenhc@lemote.com>,
Xuefeng Li <lixuefeng@loongson.cn>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Yinglu Yang <yangyinglu@loongson.cn>
Subject: Re: [PATCH v2,RESEND] MIPS: Scan the DMI system information
Date: Wed, 5 Feb 2020 10:11:26 +0100 [thread overview]
Message-ID: <20200205101126.4fad0946@endymion> (raw)
In-Reply-To: <17537451580871338@vla4-87a00c2d2b1b.qloud-c.yandex.net>
On Wed, 05 Feb 2020 10:55:38 +0800, Jiaxun Yang wrote:
> > I think it is better to split it into the following two patches?
> > [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
> > [PATCH v3 2/2] MIPS: Add support for Desktop Management Interface (DMI)
>
> That way will break bisect.
Are you sure? As far as I can see, each patch builds individually. The
dmi patch is a no-op alone. The mips patch will not work alone,
obviously, however according to Tiezhu dmi_scan_machine() will fail
with a harmless error message if the base address is 0xF0000. If that's
correct then it's not breaking bisect.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2020-02-05 9:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 13:26 [PATCH v2,RESEND] MIPS: Scan the DMI system information Tiezhu Yang
2020-02-03 8:32 ` Tiezhu Yang
2020-02-03 12:14 ` Jean Delvare
2020-02-05 2:28 ` Tiezhu Yang
2020-02-05 2:55 ` Jiaxun Yang
2020-02-05 5:01 ` Tiezhu Yang
2020-02-05 9:11 ` Jean Delvare [this message]
2020-02-06 7:04 ` Jiaxun Yang
2020-02-03 14:46 ` Jonas Gorski
2020-02-05 2:13 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205101126.4fad0946@endymion \
--to=jdelvare@suse.de \
--cc=chenhc@lemote.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=yangtiezhu@loongson.cn \
--cc=yangyinglu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox