From: Quentin Perret <qperret@google.com>
To: Matthias Maennich <maennich@google.com>
Cc: masahiroy@kernel.org, nico@fluxnic.net,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
kernel-team@android.com, jeyu@kernel.org
Subject: Re: [PATCH v2] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS
Date: Wed, 5 Feb 2020 11:53:31 +0000 [thread overview]
Message-ID: <20200205115331.GA74296@google.com> (raw)
In-Reply-To: <20200204144415.GC42496@google.com>
On Tuesday 04 Feb 2020 at 14:44:15 (+0000), 'Matthias Maennich' via kernel-team wrote:
> That definitely looks like I would expect that config option to work.
Good, thank you, I'll send an update.
And while at it, I realized we could actually pre-populate autoksyms.h
very early on with the content of the whitelist instead of having it
empty. That way, there's a whole lot of things that will be compiled
'correctly' from the start (that is, adjust_autoksyms.sh won't need to
re-compile them later on). And in fact, if all symbols used by in-tree
modules happen to already be on the whitelist, you'll build a trimmed
kernel in a single pass, which should improve build time a bit I hope.
I'll add something to v3 in addition to your suggestion.
Thanks,
Quentin
next prev parent reply other threads:[~2020-02-05 11:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 18:15 [PATCH v2] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS Quentin Perret
2020-01-29 18:29 ` Nicolas Pitre
2020-01-31 13:15 ` Matthias Maennich
2020-01-31 17:40 ` Quentin Perret
2020-02-04 14:44 ` Matthias Maennich
2020-02-05 11:53 ` Quentin Perret [this message]
2020-02-06 15:56 ` Jessica Yu
2020-02-06 16:12 ` Nicolas Pitre
2020-02-06 16:17 ` Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205115331.GA74296@google.com \
--to=qperret@google.com \
--cc=jeyu@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=masahiroy@kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox