From: Masami Hiramatsu <mhiramat@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Tom Zanussi <zanussi@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] tracing/kprobe: Fix uninitialized variable bug
Date: Thu, 6 Feb 2020 08:45:33 +0900 [thread overview]
Message-ID: <20200206084533.14d4f105e2d45e6a0dcf6527@kernel.org> (raw)
In-Reply-To: <20200205223404.GA3379@embeddedor>
On Wed, 5 Feb 2020 16:34:04 -0600
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> There is a potential execution path in which variable *ret* is returned
> without being properly initialized, previously.
>
> Fix this by initializing variable *ret* to 0.
Good catch!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
>
> Addresses-Coverity-ID: 1491142 ("Uninitialized scalar variable")
> Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation functions")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> kernel/trace/trace_kprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index d8264ebb9581..362cca52f5de 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -1012,7 +1012,7 @@ int __kprobe_event_add_fields(struct dynevent_cmd *cmd, ...)
> {
> struct dynevent_arg arg;
> va_list args;
> - int ret;
> + int ret = 0;
>
> if (cmd->type != DYNEVENT_TYPE_KPROBE)
> return -EINVAL;
> --
> 2.25.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2020-02-05 23:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 22:34 [PATCH][next] tracing/kprobe: Fix uninitialized variable bug Gustavo A. R. Silva
2020-02-05 23:24 ` Tom Zanussi
2020-02-05 23:32 ` Gustavo A. R. Silva
2020-02-05 23:45 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206084533.14d4f105e2d45e6a0dcf6527@kernel.org \
--to=mhiramat@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox