Re: [PATCH v1 06/11] Documentation: pstore/blk: blkoops: create document for pstore_blk

Randy Dunlap
2020-01-22T16:08:42Z

On 1/22/20 7:01 AM, liaoweixiong wrote:
> On 2020/1/21 下午11:34, Randy Dunlap wrote:
>> On 1/21/20 12:19 AM, liaoweixiong wrote:
>>> hi Randy Dunlap,
>>>
>>> On 2020/1/21 2:36 PM, Randy Dunlap wrote:
>>>> On 1/20/20 9:23 PM, liaoweixiong wrote:
>>>>> hi Randy Dunlap,
>>>>>
>>>>> On 2020/1/21 PM12:13, Randy Dunlap wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I have some documentation comments for you:
>>>>>>
>>>>>>
>>>>>> On 1/19/20 5:03 PM, WeiXiong Liao wrote:
>>>>>>> The document, at Documentation/admin-guide/pstore-block.rst, tells us
>>>>>>> how to use pstore/blk and blkoops.
>>>>>>>
>>>>>>> Signed-off-by: WeiXiong Liao <liaoweixiong@allwinnertech.com>
>>>>>>> ---
>>>>>>>    Documentation/admin-guide/pstore-block.rst | 278 +++++++++++++++++++++++++++++
>>>>>>>    MAINTAINERS                                |   1 +
>>>>>>>    fs/pstore/Kconfig                          |   2 +
>>>>>>>    3 files changed, 281 insertions(+)
>>>>>>>    create mode 100644 Documentation/admin-guide/pstore-block.rst
>>>>>>>
>>>>>>> diff --git a/Documentation/admin-guide/pstore-block.rst b/Documentation/admin-guide/pstore-block.rst
>>>>>>> new file mode 100644
>>>>>>> index 000000000000..58418d429c55
>>>>>>> --- /dev/null
>>>>>>> +++ b/Documentation/admin-guide/pstore-block.rst

>>>>>>> +Compression and header
>>>>>>> +----------------------
>>>>>>> +
>>>>>>> +Block device is large enough for uncompressed dmesg data. Actually we do not
>>>>>>> +recommend data compression because pstore/blk will insert some information into
>>>>>>> +the first line of dmesg data. For example::
>>>>>>> +
>>>>>>> +        Panic: Total 16 times
>>>>>>> +
>>>>>>> +It means that it's the 16th times panic log since the first booting. Sometimes
>>>>>>
>>>>>>                                  time of a panic log since ...
>>>>>>
>>>>>
>>>>> Should it be like this?
>>>>> It means the time of a panic log since the first booting.
>>>>
>>>> That sounds like clock time, not the number of instances or occurrences.
>>>>
>>>
>>> It is an oops/panic counter too. How about this?
>>>
>>> It means that it's OOPS/PANIC for the 16th time since the first booting.
>>
>>                                                    since the last booting {or boot}.
>>
>
> Not the last booting but the first booting. This is the number of
> triggers since the first time the system was installed.

OK, so it's a persistent counter.
Thanks for the clarification.

--
~Randy