RE: [PATCH 1/2] dt-bindings: arm: arm,scmi: add smc/hvc transports

Peng Fan
2020-02-10T00:59:50Z

> Subject: [PATCH 1/2] dt-bindings: arm: arm,scmi: add smc/hvc transports
>
> From: Peng Fan <peng.fan@nxp.com>
>
> SCMI could use SMC/HVC as tranports, so add into devicetree binding doc.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/arm,scmi.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt
> b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> index f493d69e6194..03cff8b55a93 100644
> --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt
> +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> @@ -14,7 +14,7 @@ Required properties:
>
> The scmi node with the following properties shall be under the /firmware/
> node.
>
> -- compatible : shall be "arm,scmi"
> +- compatible : shall be "arm,scmi" or "arm,scmi-smc"

One question here, are you fine with compatible "arm,scmi-smc" or
add a new property 'transport' such as:
transport = "mailbox"; for mailbox
transport = "smc"; for smc and hvc.

Thanks,
Peng.

> - mboxes: List of phandle and mailbox channel specifiers. It should contain
> exactly one or two mailboxes, one for transmitting messages("tx")
> and another optional for receiving the notifications("rx") if @@ -25,6
> +25,8 @@ The scmi node with the following properties shall be under the
> /firmware/ node.
> protocol identifier for a given sub-node.
> - #size-cells : should be '0' as 'reg' property doesn't have any size
> associated with it.
> +- arm,smc-id : SMC id required when using smc transports
> +- arm,hvc-id : HVC id required when using hvc transports
>
> Optional properties:
>
> --
> 2.16.4