Re: [PATCH] checkpatch: Remove email address comment from email address comparisons

Andrew Morton
2020-02-10T22:25:35Z

On Mon, 10 Feb 2020 10:52:16 -0800 Joe Perches <joe@perches.com> wrote:

> About 2% of the last 100K commits have email addresses that include an
> RFC2822 compliant comment like:
>
> Peter Zijlstra (Intel) <peterz@infradead.org>
>
> checkpatch currently does a comparison of the complete name and address
> to the submitted author to determine if the author has signed-off and
> emits a warning if the exact email names and addresses do not match.

Yes, I've seen this a few times.

> Unfortunately, the author email address can be written without the comment
> like:
>
> Peter Zijlstra <peterz@infradead.org>
>
> Add logic to compare the comment stripped email addresses to avoid this
> warning.

Where "stripped" means "after removing stuff in parentheses"?

Why do we consider the display name at all? It's the
"peterz@infradead.org" part which matters for comparison purposes?