Re: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

Greg Ungerer
2020-02-03T01:20:44Z

Hi Peter,

On 31/1/20 11:19 pm, Greg Ungerer wrote:
> On 31/1/20 10:45 pm, Peter Zijlstra wrote:
>> In order to faciliate Will's READ_ONCE() patches:
>>
>>    https://lkml.kernel.org/r/20200123153341.19947-1-will@kernel.org
>>
>> we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
>> are tested using ARAnyM/68040.
>>
>> Michael tested the previous version on his Atari Falcon/68030.
>>
>> Build tested for sun3/coldfire.
>
> Thanks for the quick turn around. Build looks good for me too with
> this new series. I will test on real hardware on Monday.

So this tests good for me on real hardware. I had a look over the
ColdFire changes and I have no problems with anything.
So for the ColdFire parts:

Tested-by: Greg Ungerer <gerg@linux-m68k.org>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>

Regards
Greg

>> Please consider!
>>
>> Changes since -v1:
>>   - fixed sun3/coldfire build issues
>>   - unified motorola mmu page setup
>>   - added enum to table allocator
>>   - moved pointer table allocator to motorola.c
>>   - converted coldfire pgtable_t
>>   - fixed coldfire pgd_alloc
>>   - fixed coldfire nocache
>>
>> ---
>>   arch/m68k/include/asm/mcf_pgalloc.h      |  31 ++---
>>   arch/m68k/include/asm/motorola_pgalloc.h |  74 ++++------
>>   arch/m68k/include/asm/motorola_pgtable.h |  36 +++--
>>   arch/m68k/include/asm/page.h             |  16 ++-
>>   arch/m68k/include/asm/pgtable_mm.h       |  10 +-
>>   arch/m68k/mm/init.c                      |  34 +++--
>>   arch/m68k/mm/kmap.c                      |  36 +++--
>>   arch/m68k/mm/memory.c                    | 103 --------------
>>   arch/m68k/mm/motorola.c                  | 228 +++++++++++++++++++++++++------
>>   9 files changed, 302 insertions(+), 266 deletions(-)
>>
>>