public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf stat: Show percore counts in per CPU output
Date: Mon, 10 Feb 2020 14:28:04 +0100	[thread overview]
Message-ID: <20200210132804.GA9922@krava> (raw)
In-Reply-To: <20200206015613.527-1-yao.jin@linux.intel.com>

On Thu, Feb 06, 2020 at 09:56:13AM +0800, Jin Yao wrote:
> We have supported the event modifier "percore" which sums up the
> event counts for all hardware threads in a core and show the counts
> per core.
> 
> For example,
> 
>  # perf stat -e cpu/event=cpu-cycles,percore/ -a -A -- sleep 1
> 
>   Performance counter stats for 'system wide':
> 
>  S0-D0-C0                395,072      cpu/event=cpu-cycles,percore/
>  S0-D0-C1                851,248      cpu/event=cpu-cycles,percore/
>  S0-D0-C2                954,226      cpu/event=cpu-cycles,percore/
>  S0-D0-C3              1,233,659      cpu/event=cpu-cycles,percore/
> 
> This patch provides a new option "--percore-show-thread". It is
> used with event modifier "percore" together to sum up the event counts
> for all hardware threads in a core but show the counts per hardware
> thread.
> 
> For example,
> 
>  # perf stat -e cpu/event=cpu-cycles,percore/ -a -A --percore-show-thread  -- sleep 1
> 
>   Performance counter stats for 'system wide':
> 
>  CPU0               2,453,061      cpu/event=cpu-cycles,percore/
>  CPU1               1,823,921      cpu/event=cpu-cycles,percore/
>  CPU2               1,383,166      cpu/event=cpu-cycles,percore/
>  CPU3               1,102,652      cpu/event=cpu-cycles,percore/
>  CPU4               2,453,061      cpu/event=cpu-cycles,percore/
>  CPU5               1,823,921      cpu/event=cpu-cycles,percore/
>  CPU6               1,383,166      cpu/event=cpu-cycles,percore/
>  CPU7               1,102,652      cpu/event=cpu-cycles,percore/

I don't understand how is this different from -A output:

  # ./perf stat -e cpu/event=cpu-cycles/ -A  
  ^C
   Performance counter stats for 'system wide':

  CPU0              56,847,497      cpu/event=cpu-cycles/                                       
  CPU1              75,274,384      cpu/event=cpu-cycles/                                       
  CPU2              63,866,342      cpu/event=cpu-cycles/                                       
  CPU3              89,559,693      cpu/event=cpu-cycles/                                       
  CPU4              74,761,132      cpu/event=cpu-cycles/                                       
  CPU5              76,320,191      cpu/event=cpu-cycles/                                       
  CPU6              55,100,175      cpu/event=cpu-cycles/                                       
  CPU7              48,472,895      cpu/event=cpu-cycles/                                       

       1.074800857 seconds time elapsed

also the interval output is mangled:

  # ./perf stat -e cpu/event=cpu-cycles,percore/ -a -A --percore-show-thread  -I 1000
  #           time CPU                    counts unit events
     1.000177375      1.000177375 CPU0             138,483,540      cpu/event=cpu-cycles,percore/                                   
     1.000177375      1.000177375 CPU1             143,159,477      cpu/event=cpu-cycles,percore/                                   
     1.000177375      1.000177375 CPU2             177,554,642      cpu/event=cpu-cycles,percore/                                   
     1.000177375      1.000177375 CPU3             150,974,512      cpu/event=cpu-cycles,percore/                                   
     1.000177375      1.000177375 CPU4             138,483,540      cpu/event=cpu-cycles,percore/                                   
     1.000177375      1.000177375 CPU5             143,159,477      cpu/event=cpu-cycles,percore/                                   
     1.000177375      1.000177375 CPU6             177,554,642      cpu/event=cpu-cycles,percore/                                   

jirka


  reply	other threads:[~2020-02-10 13:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06  1:56 [PATCH] perf stat: Show percore counts in per CPU output Jin Yao
2020-02-10 13:28 ` Jiri Olsa [this message]
2020-02-10 13:46   ` Jin, Yao
2020-02-10 14:01     ` Jiri Olsa
2020-02-10 17:01       ` Andi Kleen
2020-02-10 21:04         ` Jiri Olsa
2020-02-11  1:48           ` Jin, Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200210132804.GA9922@krava \
    --to=jolsa@redhat.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox