From: Mark Brown <broonie@kernel.org>
To: Brent Lu <brent.lu@intel.com>
Cc: alsa-devel@alsa-project.org,
Support Opensource <support.opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, cychiang@google.com,
mac.chiang@intel.com
Subject: Re: [PATCH] ASoC: da7219: check SRM lock in trigger callback
Date: Mon, 10 Feb 2020 18:59:05 +0000 [thread overview]
Message-ID: <20200210185905.GD14166@sirena.org.uk> (raw)
In-Reply-To: <1581322611-25695-1-git-send-email-brent.lu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
On Mon, Feb 10, 2020 at 04:16:51PM +0800, Brent Lu wrote:
> Intel sst firmware turns on BCLK/WCLK in START Ioctl call which timing is
> later than the DAPM SUPPLY event handler da7219_dai_event is called (in
> PREPARED state). Therefore, the SRM lock check always fail.
>
> Moving the check to trigger callback could ensure the SRM is locked before
> DSP starts to process data and avoid possisble noise.
Independently of any other discussion trigger is expected to run very
fast so doesn't feel like a good place to do this - given that we're
talking about doing this to avoid noise the mute operation seems like a
more idiomatic place to do this, it exists to avoid playing back
glitches from the digitial interface during startup.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-10 18:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 8:16 [PATCH] ASoC: da7219: check SRM lock in trigger callback Brent Lu
2020-02-10 14:18 ` [alsa-devel] " Pierre-Louis Bossart
[not found] ` <CAOReqxhHfTuj6mxeX2e_ejMY8N4u+BFLfzKDgn=y5EbWLL_joA@mail.gmail.com>
2020-02-10 16:07 ` Pierre-Louis Bossart
[not found] ` <CAOReqxiNomQ7OOoE8LHWKH_LkaerSgsO-Yr4918Az2e_50THaA@mail.gmail.com>
2020-02-11 4:00 ` Fletcher Woodruff
2020-02-10 14:32 ` Adam Thomson
2020-02-11 10:08 ` Lu, Brent
2020-02-11 16:30 ` [alsa-devel] " Pierre-Louis Bossart
[not found] ` <CAFQqKeWHDyyd_YBBaD6P2sCL5OCNEsiUU6B7eUwtiLv8GZU0yg@mail.gmail.com>
2020-02-11 21:12 ` Pierre-Louis Bossart
[not found] ` <CAFQqKeXK3OG7KXaHGUuC75sxWrdf11xJooC7XsDCOyd6KUgPTQ@mail.gmail.com>
2020-02-11 21:49 ` Pierre-Louis Bossart
2020-02-12 10:16 ` Adam Thomson
2020-02-12 11:59 ` Mark Brown
2020-02-12 15:48 ` Pierre-Louis Bossart
2020-02-12 17:01 ` Adam Thomson
2020-02-19 5:57 ` Lu, Brent
2020-02-19 10:05 ` Adam Thomson
2020-02-10 18:59 ` Mark Brown [this message]
2020-02-11 10:19 ` Lu, Brent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210185905.GD14166@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=cychiang@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=perex@perex.cz \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox