From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 199B6C3B186 for ; Mon, 10 Feb 2020 19:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFDDE20838 for ; Mon, 10 Feb 2020 19:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581362279; bh=ZyB0HayJV9hA11EQE3OHddet92bzHEDctB8rpbAnB2A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GsgvNmtvf4/kP53F9G2Mb6C4wu9bDHcYWccrOjTbmWjwqBCfDdNomdmcRKp1ZRjOf 5pzqv8Cd150att8IQba+4fk0zBXxCf2qYzdVHsJaR7MBfnirFH9nDZlwjORqXY71CP cXSvVzcSEnhYIRO6uCTOFk9dyqPrf1FmENLTdDXw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727579AbgBJTR7 (ORCPT ); Mon, 10 Feb 2020 14:17:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:46698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726831AbgBJTR7 (ORCPT ); Mon, 10 Feb 2020 14:17:59 -0500 Received: from localhost (unknown [104.132.1.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2ED2E20661; Mon, 10 Feb 2020 19:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581362278; bh=ZyB0HayJV9hA11EQE3OHddet92bzHEDctB8rpbAnB2A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JjcZB5vn0hUrVokfNT8lpRNWPpvf6xsZ2XP8QGuI4TuiuMUmBl7rECwc++d/GJtv4 cSdjcYYCvTkpCV9T2upXleimEwzmh6OUdTftd8tZynfo8dRKWMolDaOyDmW7D3b78o 7CBSY4X4loVfQg71m2RNPCZXUgsz0m4JKBWGhEVg= Date: Mon, 10 Feb 2020 11:17:57 -0800 From: Greg Kroah-Hartman To: Pavel Shilovskiy Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Aurelien Aptel , Steven French Subject: Re: [EXTERNAL] [PATCH 5.4 303/309] cifs: fix mode bits from dir listing when mounted with modefromsid Message-ID: <20200210191757.GA1098324@kroah.com> References: <20200210122406.106356946@linuxfoundation.org> <20200210122436.056141941@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2020 at 07:10:00PM +0000, Pavel Shilovskiy wrote: > > -----Original Message Begin----- > From: Greg Kroah-Hartman > Sent: Monday, February 10, 2020 4:34 AM > To: linux-kernel@vger.kernel.org > Cc: Greg Kroah-Hartman ; stable@vger.kernel.org; Aurelien Aptel ; Steven French ; Pavel Shilovskiy > Subject: [EXTERNAL] [PATCH 5.4 303/309] cifs: fix mode bits from dir listing when mounted with modefromsid > > From: Aurelien Aptel > > commit e3e056c35108661e418c803adfc054bf683426e7 upstream. > > When mounting with -o modefromsid, the mode bits are stored in an ACE. Directory enumeration (e.g. ls -l /mnt) triggers an SMB Query Dir which does not include ACEs in its response. The mode bits in this case are silently set to a default value of 755 instead. > > This patch marks the dentry created during the directory enumeration as needing re-evaluation (i.e. additional Query Info with ACEs) so that the mode bits can be properly extracted. > > Quick repro: > > $ mount.cifs //win19.test/data /mnt -o ...,modefromsid $ touch /mnt/foo && chmod 751 /mnt/foo $ stat /mnt/foo > # reports 751 (OK) > $ sleep 2 > # dentry older than 1s by default get invalidated $ ls -l /mnt > # since dentry invalid, ls does a Query Dir > # and reports foo as 755 (WRONG) > > Signed-off-by: Aurelien Aptel > Signed-off-by: Steve French > CC: Stable > Reviewed-by: Pavel Shilovsky > Signed-off-by: Greg Kroah-Hartman > > --- > fs/cifs/readdir.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- a/fs/cifs/readdir.c > +++ b/fs/cifs/readdir.c > @@ -174,7 +174,8 @@ cifs_fill_common_info(struct cifs_fattr > * may look wrong since the inodes may not have timed out by the time > * "ls" does a stat() call on them. > */ > - if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_ACL) > + if ((cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_ACL) || > + (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MODE_FROM_SID)) > fattr->cf_flags |= CIFS_FATTR_NEED_REVAL; > > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_UNX_EMUL && > > -----Original Message End----- > > Hi Greg, > > This patch fixes the following commit that was introduced in v5.5: > > commit fdef665ba44ad5ed154af2acfb19ae2ee3bf5dcc > Author: Steve French > Date: Fri Dec 6 02:02:38 2019 -0600 > > smb3: fix mode passed in on create for modetosid mount option > > > Please remove the patch from all stable trees expect 5.5.y. Now dropped, thanks for letting me know. greg k-h