From: Quentin Perret <qperret@google.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: masahiroy@kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, maennich@google.com,
kernel-team@android.com, jeyu@kernel.org, hch@infradead.org
Subject: Re: [PATCH v3 1/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS
Date: Tue, 11 Feb 2020 05:41:42 +0000 [thread overview]
Message-ID: <20200211054142.GA72419@google.com> (raw)
In-Reply-To: <nycvar.YSQ.7.76.2002071319200.1559@knanqh.ubzr>
On Friday 07 Feb 2020 at 13:22:12 (-0500), Nicolas Pitre wrote:
> This "[[ ]]" is a bashism. I think there was an effort not to depend on
> bash for the build system.
OK, I see.
> So either this needs to be changed to basic
> bourne shell, or the interpretor has to be /bin/bash not /bin/sh.
So, as per the above, the basic bourne shell option sounds preferable,
I'll go fix this for v4.
Thanks,
Quentin
next prev parent reply other threads:[~2020-02-11 5:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 18:07 [PATCH v3 0/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYM Quentin Perret
2020-02-07 18:07 ` [PATCH v3 1/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS Quentin Perret
2020-02-07 18:22 ` Nicolas Pitre
2020-02-11 5:41 ` Quentin Perret [this message]
2020-02-08 5:05 ` Masahiro Yamada
2020-02-11 5:44 ` Quentin Perret
2020-02-07 18:07 ` [PATCH v3 2/3] kbuild: split adjust_autoksyms.sh in two parts Quentin Perret
2020-02-08 5:08 ` Masahiro Yamada
2020-02-11 5:45 ` Quentin Perret
2020-02-07 18:07 ` [PATCH v3 3/3] kbuild: generate autoksyms.h early Quentin Perret
2020-02-08 5:09 ` Masahiro Yamada
2020-02-11 5:46 ` Quentin Perret
2020-02-11 2:14 ` kbuild test robot
2020-02-12 19:56 ` Quentin Perret
[not found] ` <20200213084251.GU12867@shao2-debian>
2020-02-13 18:07 ` [kbuild-all] " Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211054142.GA72419@google.com \
--to=qperret@google.com \
--cc=hch@infradead.org \
--cc=jeyu@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=masahiroy@kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).