Re: [PATCH v5 07/18] platform/x86: intel_scu_ipc: Add managed function to register SCU IPC

Andy Shevchenko
2020-02-11T15:51:35Z

On Tue, Feb 11, 2020 at 04:25:52PM +0300, Mika Westerberg wrote:
> Drivers such as intel_pmc_ipc.c can be unloaded as well so in order to
> support those in this driver add a new function that can be called to
> unregister the SCU IPC when it is not needed anymore.
>
> We also add a managed version of the intel_scu_ipc_register() that takes
> care of calling intel_scu_ipc_unregister() automatically when the driver
> is unbound.

...

> + devres = devres_alloc(devm_intel_scu_ipc_unregister, sizeof(*devres),
> + GFP_KERNEL);

Maybe devres -> dr and put on one line?
But it's up to you, I'm fine with the current as well.

--
With Best Regards,
Andy Shevchenko