Re: [PATCH] firmware/dmi: Report DMI Bios & EC firmware release

[Jean Delvare <jdelvare@suse.de>]

On Fri,  7 Feb 2020 09:35:47 +0100, Erwan Velu wrote:
> Some vendors like HPe or Dell, encode the release version of their BIOS
> in the "System BIOS {Major|Minor} Release" fields of Type 0.
> 
> This information is used to know which bios release actually runs.
> It could be used for some quirks, debugging sessions or inventory tasks.
> 
> A typical output for a Dell system running the 65.27 bios is :
> 	[root@t1700 ~]# cat /sys/devices/virtual/dmi/id/bios_release
> 	65.27
> 	[root@t1700 ~]#
> 
> Servers that have a BMC encode the release version of their firmware in the
>  "Embedded Controller Firmware {Major|Minor} Release" fields of Type 0.
> 
> This information is used to know which BMC release actually runs.
> It could be used for some quirks, debugging sessions or inventory tasks.
> 
> A typical output for a Dell system running the 3.75 bmc release is :
>     [root@t1700 ~]# cat /sys/devices/virtual/dmi/id/ec_firmware_release
>     3.75
>     [root@t1700 ~]#
> 
> Signed-off-by: Erwan Velu <e.velu@criteo.com>
> ---
>  drivers/firmware/dmi-id.c       |  6 ++++++
>  drivers/firmware/dmi_scan.c     | 30 ++++++++++++++++++++++++++++++
>  include/linux/mod_devicetable.h |  2 ++
>  scripts/mod/file2alias.c        |  2 ++
>  4 files changed, 40 insertions(+)
> (...)

Applied, thanks. Note that I went for "efr" as the shortcut string for
DMI_EC_FIRMWARE_RELEASE, which was your first choice and has my
preference.

-- 
Jean Delvare
SUSE L3 Support