From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A1F2C352A3 for ; Tue, 11 Feb 2020 13:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3808F20675 for ; Tue, 11 Feb 2020 13:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728965AbgBKNVY (ORCPT ); Tue, 11 Feb 2020 08:21:24 -0500 Received: from mx2.suse.de ([195.135.220.15]:40166 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728197AbgBKNVY (ORCPT ); Tue, 11 Feb 2020 08:21:24 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 13D4EB19C; Tue, 11 Feb 2020 13:21:19 +0000 (UTC) Date: Tue, 11 Feb 2020 14:21:12 +0100 From: Jean Delvare To: Erwan Velu Cc: Erwan Velu , Masahiro Yamada , Michal Marek , Mattias Jacobsson <2pi@mok.nu>, Andy Shevchenko , Andrew Lunn , "Darren Hart (VMware)" , Changbin Du , Russell King , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH] firmware/dmi: Report DMI Bios & EC firmware release Message-ID: <20200211142112.649d7237@endymion> In-Reply-To: <20200207083550.360461-1-e.velu@criteo.com> References: <20200207083550.360461-1-e.velu@criteo.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Feb 2020 09:35:47 +0100, Erwan Velu wrote: > Some vendors like HPe or Dell, encode the release version of their BIOS > in the "System BIOS {Major|Minor} Release" fields of Type 0. > > This information is used to know which bios release actually runs. > It could be used for some quirks, debugging sessions or inventory tasks. > > A typical output for a Dell system running the 65.27 bios is : > [root@t1700 ~]# cat /sys/devices/virtual/dmi/id/bios_release > 65.27 > [root@t1700 ~]# > > Servers that have a BMC encode the release version of their firmware in the > "Embedded Controller Firmware {Major|Minor} Release" fields of Type 0. > > This information is used to know which BMC release actually runs. > It could be used for some quirks, debugging sessions or inventory tasks. > > A typical output for a Dell system running the 3.75 bmc release is : > [root@t1700 ~]# cat /sys/devices/virtual/dmi/id/ec_firmware_release > 3.75 > [root@t1700 ~]# > > Signed-off-by: Erwan Velu > --- > drivers/firmware/dmi-id.c | 6 ++++++ > drivers/firmware/dmi_scan.c | 30 ++++++++++++++++++++++++++++++ > include/linux/mod_devicetable.h | 2 ++ > scripts/mod/file2alias.c | 2 ++ > 4 files changed, 40 insertions(+) > (...) Applied, thanks. Note that I went for "efr" as the shortcut string for DMI_EC_FIRMWARE_RELEASE, which was your first choice and has my preference. -- Jean Delvare SUSE L3 Support