From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E60EFC352A3 for ; Tue, 11 Feb 2020 15:51:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C736420714 for ; Tue, 11 Feb 2020 15:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730589AbgBKPve (ORCPT ); Tue, 11 Feb 2020 10:51:34 -0500 Received: from mga12.intel.com ([192.55.52.136]:15704 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730315AbgBKPvc (ORCPT ); Tue, 11 Feb 2020 10:51:32 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 07:51:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="227535738" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008.fm.intel.com with ESMTP; 11 Feb 2020 07:51:28 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1j1Xov-000luG-1T; Tue, 11 Feb 2020 17:51:29 +0200 Date: Tue, 11 Feb 2020 17:51:29 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: Darren Hart , Lee Jones , Greg Kroah-Hartman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , "David E . Box" , Guenter Roeck , Heikki Krogerus , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 07/18] platform/x86: intel_scu_ipc: Add managed function to register SCU IPC Message-ID: <20200211155129.GG10400@smile.fi.intel.com> References: <20200211132603.73509-1-mika.westerberg@linux.intel.com> <20200211132603.73509-8-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200211132603.73509-8-mika.westerberg@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 04:25:52PM +0300, Mika Westerberg wrote: > Drivers such as intel_pmc_ipc.c can be unloaded as well so in order to > support those in this driver add a new function that can be called to > unregister the SCU IPC when it is not needed anymore. > > We also add a managed version of the intel_scu_ipc_register() that takes > care of calling intel_scu_ipc_unregister() automatically when the driver > is unbound. ... > + devres = devres_alloc(devm_intel_scu_ipc_unregister, sizeof(*devres), > + GFP_KERNEL); Maybe devres -> dr and put on one line? But it's up to you, I'm fine with the current as well. -- With Best Regards, Andy Shevchenko