Re: [PATCH v2 10/25] fs: Introduce i_blocks_per_page

Matthew Wilcox
2020-02-12T15:05:42Z

On Tue, Feb 11, 2020 at 11:44:53PM -0800, Christoph Hellwig wrote:
> Looks good modulo some nitpicks below:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> > + * Context: Any context.
>
> Does this add any value for a trivial helper like this?

I think it's good to put them in to remind people they should be putting
them in for more complex functions. Just like the Return: section.

> > + * Return: The number of filesystem blocks covered by this page.
> > + */
> > +static inline
> > +unsigned int i_blocks_per_page(struct inode *inode, struct page *page)
>
> static inline unisnged int
> i_blocks_per_page(struct inode *inode, struct page *page)

That's XFS coding style. Linus has specifically forbidden that: