Re: [PATCH v2 05/25] mm: Fix documentation of FGP flags

Christoph Hellwig
2020-02-12T07:42:16Z

On Tue, Feb 11, 2020 at 08:18:25PM -0800, Matthew Wilcox wrote:
> - * @fgp_flags: PCG flags
> + * @fgp_flags: FGP flags
> * @gfp_mask: gfp mask to use for the page cache data page allocation
> *
> * Looks up the page cache slot at @mapping & @offset.
> *
> - * PCG flags modify how the page is returned.
> + * FGP flags modify how the page is returned.

This still looks weird. Why not just a single line:

* @fgp_flags: FGP_* flags that control how the page is returned.