From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE48C352A4 for ; Wed, 12 Feb 2020 21:14:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2DB3206D7 for ; Wed, 12 Feb 2020 21:14:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HAwpIjIJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729156AbgBLVOF (ORCPT ); Wed, 12 Feb 2020 16:14:05 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:45048 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728603AbgBLVOE (ORCPT ); Wed, 12 Feb 2020 16:14:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-Id:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=XeL6LCi2HGnzcbE5ZCpOQlzWnrcj0g6s0cgd62YAoiY=; b=HAwpIjIJVIGdFIoZiecd/0UD7+ udWSr7SKk1ECZ2X0vteEc1DvtPPKL0Mw1g8PCc99lv2UqBMdvnqjTGDEt95DKasSx6S+tAtmojyPL XLlpNO3uVbpJfrhn9htq4tAqCoNuz215NwM8dlxBvYHMoSRGlo2QKyI5ceqnMEmx8GMEDpkkNVR6k SXAn2UzOOX+d4/QQB+f2pAXe7eJWbjoHq4Ppx+p7zyLgLtQ1wE2pllyZK8Gc9qHkY/P4aQRPJ9xQt 0Toup6ENXXcx03Uu7r11+kHBx1esimC2tXgsUd4ViAY9UO8CqUX6l9lnPcse5JicnkjJW239CCicU D6OGNRFw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1zKL-0001Az-Le; Wed, 12 Feb 2020 21:13:45 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C7A6B307793; Wed, 12 Feb 2020 22:11:52 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 8DAC1203A89AA; Wed, 12 Feb 2020 22:13:41 +0100 (CET) Message-Id: <20200212210750.255616631@infradead.org> User-Agent: quilt/0.65 Date: Wed, 12 Feb 2020 22:01:47 +0100 From: Peter Zijlstra To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, rostedt@goodmis.org Cc: peterz@infradead.org, mingo@kernel.org, joel@joelfernandes.org, gregkh@linuxfoundation.org, gustavo@embeddedor.com, tglx@linutronix.de, paulmck@kernel.org, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com Subject: [PATCH v2 8/9] tracing: Remove regular RCU context for _rcuidle tracepoints (again) References: <20200212210139.382424693@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Effectively revert commit 865e63b04e9b2 ("tracing: Add back in rcu_irq_enter/exit_irqson() for rcuidle tracepoints") now that we've taught perf how to deal with not having an RCU context provided. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/tracepoint.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -179,10 +179,8 @@ static inline struct tracepoint *tracepo * For rcuidle callers, use srcu since sched-rcu \ * doesn't work from the idle path. \ */ \ - if (rcuidle) { \ + if (rcuidle) \ __idx = srcu_read_lock_notrace(&tracepoint_srcu);\ - rcu_irq_enter_irqsave(); \ - } \ \ it_func_ptr = rcu_dereference_raw((tp)->funcs); \ \ @@ -194,10 +192,8 @@ static inline struct tracepoint *tracepo } while ((++it_func_ptr)->func); \ } \ \ - if (rcuidle) { \ - rcu_irq_exit_irqsave(); \ + if (rcuidle) \ srcu_read_unlock_notrace(&tracepoint_srcu, __idx);\ - } \ \ preempt_enable_notrace(); \ } while (0)