From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A64C352A3 for ; Thu, 13 Feb 2020 05:43:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05644217F4 for ; Thu, 13 Feb 2020 05:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581572635; bh=4syaKUKu77FngS2/xeaFk/gtszZv6o9gBJ+A5aYg8KU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uQ8bM2aiT76VO50Kt2tFVRV7CSblM7xE8uVZrrDTFts9y2tT8gAwdNM7oKUbu5dZe w79iBkWkrbMk9x6TS1zSHRV/7umbrP2H4egeM/oIrNhasCpFkayN+0DGTqP+7UDBG7 MkUGhJQrHOnJlFtPomPWaKaqwGGiQIMXdNlLyoeE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729562AbgBMFny (ORCPT ); Thu, 13 Feb 2020 00:43:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:57422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbgBMFnx (ORCPT ); Thu, 13 Feb 2020 00:43:53 -0500 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CEC220873; Thu, 13 Feb 2020 05:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581572633; bh=4syaKUKu77FngS2/xeaFk/gtszZv6o9gBJ+A5aYg8KU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RMT4njs9CqOEjaxrgfxN4wrm4Uhh6yv/5opMDMKEcFVMDRrz2yQbvzd3Cwfe7WGL5 2PHPd0Q7VIzWPMHxRDU5SmLfuRPft18+xurNzc1Kn+7wln6WeOQ7+Bmb/yRt9d/WyK PNYEc8J6a3Kya+FiJPg82yFvjKLc1YHh/CuL2jkY= Date: Thu, 13 Feb 2020 13:43:45 +0800 From: Shawn Guo To: Peng Fan Cc: Jacky Bai , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "allison@lohutok.net" , "info@metux.net" , Anson Huang , Leonard Crestez , "git@andred.net" , Abel Vesa , "ard.biesheuvel@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC 1/4] ARM: imx: use device_initcall for imx_soc_device_init Message-ID: <20200213054344.GM11096@dragon> References: <1579167145-1480-1-git-send-email-peng.fan@nxp.com> <1579167145-1480-2-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 17, 2020 at 08:15:54AM +0000, Peng Fan wrote: > > > Subject: [RFC 1/4] ARM: imx: use device_initcall for > > > imx_soc_device_init > > > > > > From: Peng Fan > > > > > > This is preparation to move imx_soc_device_init to drivers/soc/imx/ > > > > > > There is no reason to must put dt devices under /sys/devices/soc0, > > > they could also be under /sys/devices/platform, so we could pass NULL > > > as parent when calling of_platform_default_populate. > > > > > > > This change will impact various internal test case & userspace lib, I think. > > Need to ask test team & other developer to double check the impact. > > /sys/devices/soc0 is still there, the patchset only moves > the platform devices which under /sys/devices/soc0 to /sys/devices/platform Jacky's concern still stands, as there are many user spaces which will be broken and need update. > In this way, we aligned with ARM64. And simplify arch code by moving > the code to drivers/soc/imx. In future, considering more cleanup, > we could merge the code to soc-imx8.c, since they share similar > silicon rev ocotp logic. Though this is a good thing from maintenance point of view, we do not want to break user spaces. Shawn