From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DBC6C2BA83 for ; Thu, 13 Feb 2020 18:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18ABE222C2 for ; Thu, 13 Feb 2020 18:35:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="YqRNwkih" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728220AbgBMSfM (ORCPT ); Thu, 13 Feb 2020 13:35:12 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:36480 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727652AbgBMSfM (ORCPT ); Thu, 13 Feb 2020 13:35:12 -0500 Received: by mail-qt1-f193.google.com with SMTP id t13so5157407qto.3 for ; Thu, 13 Feb 2020 10:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=n4NsWiWBaX8kX/JR0RNwIK0qrtG2HdB1ZigjQrcyG/o=; b=YqRNwkihu+iCtxKRmM2E+hXJEe3w2EX+Dn1sOLnZdfdF5TggvyWSUeHmI2CICkWRIC M6cNuJnX8k3BsaZCGzoUdGve1KGZB4qOl9O93ZeXCxMpy2Yz5o7EPYEkxNEL73NxpJhK h6vH1lnEV70tQgdhlFfAIca7Df93Ap8oXoF1kWy+OMnd48R3AAfToJGKSujw5bEI3+9v ouQfZmL6PCe1DlYLAu07HUGRt5V6Bo7lBLQU746esYhkcn5rR4AVCpdoG/znszPWnvva 34NOL4TihfcychD+jH7vO44UdFEdpHugr3cwzz6GOem2mqjr/W7F37tRkkPkCFd2xxHO 3w/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=n4NsWiWBaX8kX/JR0RNwIK0qrtG2HdB1ZigjQrcyG/o=; b=TbTb+K/R+7x2aB/Kgdk9L4Gm637G0PKOuSRL2Rnv9CFKUIrJP0IoKue/WMBDXX9D5J wOzbgthDzD23a0gU1Zh/2i1HTnMxPlzzeE8YrwBIGnDY3nmYRbIiI61Zac8oKiSomYtp kKRMcOKpcdWtHBgaZAZuyYtwHaBCwj7IhTcF/rwfqjM5uZflL9DPPATUe3PP4ayQz816 ZxQQp8oBU2loRqgZ2XUEznP/NJkKjStn10Qmrg76iQ2FzHEuELqQkjomp/nG+amPQAoB h6quXndJvkY8iD1ljB7UA6/oXVjdvycY/pkNHnx1PiyjqfTixSol4g01XCmyDcDQv7it mEoA== X-Gm-Message-State: APjAAAWwL5AfoAcsp7hxLZH3IYpsUopotYPewqywvqzYrE5Kcgdo112T 7OwRgXAHIsNQqMJ94XJ6A57Pkw== X-Google-Smtp-Source: APXvYqxHIAXmLwvDLMLSm21f81+KTXJWcj4Fz1dQf2fBQ+dvCiWIwg6v/WhMhKZS/ijw9wqOBnUMEw== X-Received: by 2002:aed:3302:: with SMTP id u2mr12611299qtd.156.1581618909821; Thu, 13 Feb 2020 10:35:09 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id v80sm1719664qka.15.2020.02.13.10.35.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Feb 2020 10:35:08 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1j2JKO-00026F-EB; Thu, 13 Feb 2020 14:35:08 -0400 Date: Thu, 13 Feb 2020 14:35:08 -0400 From: Jason Gunthorpe To: Stefan Berger Cc: Nayna , Stefan Berger , linux-integrity@vger.kernel.org, aik@ozlabs.ru, david@gibson.dropbear.id.au, linux-kernel@vger.kernel.org, gcwilson@linux.ibm.com Subject: Re: [PATCH 3/3] tpm: ibmvtpm: Add support for TPM 2 Message-ID: <20200213183508.GL31668@ziepe.ca> References: <20200204132706.3220416-1-stefanb@linux.vnet.ibm.com> <20200204132706.3220416-4-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 13, 2020 at 01:20:12PM -0500, Stefan Berger wrote: > I don't want side effects for the TPM 1.2 case here, so I am only modifying > the flag for the case where the new TPM 2 is being used.  Here's the code > where it shows the effect. I'm surprised this driver is using AUTO_STARTUP, it was intended for embedded cases where their is no firmware to boot the TPM. Chips using AUTO_STARTUP are basically useless for PCRs/etc. I'd expect somthing called vtpm to have been started and PCRs working before Linux is started?? Jason