From: Guru Das Srinagesh <gurus@codeaurora.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND v5 2/2] pwm: core: Convert period and duty cycle to u64
Date: Thu, 13 Feb 2020 11:39:26 -0800 [thread overview]
Message-ID: <20200213193926.GA20183@codeaurora.org> (raw)
In-Reply-To: <20200213101802.owpluhixtpor3qi3@pengutronix.de>
On Thu, Feb 13, 2020 at 11:18:02AM +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Feb 12, 2020 at 10:54:08AM -0800, Guru Das Srinagesh wrote:
> > @@ -305,8 +305,8 @@ struct pwm_chip {
> > * @duty_cycle: duty cycle of the PWM signal (in nanoseconds)
> > */
> > struct pwm_capture {
> > - unsigned int period;
> > - unsigned int duty_cycle;
> > + u64 period;
> > + u64 duty_cycle;
> > };
>
> Is this last hunk a separate change?
>
> Otherwise looks fine.
Hi Uwe,
No, this is very much a part of the change and not a separate one.
If things look good to you, could you please add an Acked-by or
Reviewed-by tag to the patches so that they get accepted by Thierry?
Thank you.
Guru Das.
next prev parent reply other threads:[~2020-02-13 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 18:54 [RESEND v5 0/2] Convert period and duty cycle to u64 Guru Das Srinagesh
2020-02-12 18:54 ` [RESEND v5 1/2] pwm: Convert drivers to use 64-bit period and duty cycle Guru Das Srinagesh
2020-02-12 18:54 ` [RESEND v5 2/2] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
2020-02-13 10:18 ` Uwe Kleine-König
2020-02-13 19:39 ` Guru Das Srinagesh [this message]
2020-02-13 20:28 ` Uwe Kleine-König
2020-02-13 21:06 ` Guru Das Srinagesh
2020-02-13 21:58 ` Uwe Kleine-König
2020-02-13 22:38 ` Guru Das Srinagesh
2020-02-14 7:05 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213193926.GA20183@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).