From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DA5C352A3 for ; Sat, 15 Feb 2020 06:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98CE52067D for ; Sat, 15 Feb 2020 06:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726137AbgBOGUq (ORCPT ); Sat, 15 Feb 2020 01:20:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:48082 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbgBOGUq (ORCPT ); Sat, 15 Feb 2020 01:20:46 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F2C53B27F; Sat, 15 Feb 2020 06:20:43 +0000 (UTC) Date: Sat, 15 Feb 2020 07:20:20 +0100 From: Jean Delvare To: Wolfram Sang Cc: , Benjamin Tissoires , Phil Reid , Wolfram Sang , Robert Richter , George Cherian , Subject: Re: [PATCH 1/3] i2c: convert SMBus alert setup function to return an ERRPTR Message-ID: <20200215072020.75b1b772@endymion> In-Reply-To: <20200210172929.6001-2-wsa+renesas@sang-engineering.com> References: <20200210172929.6001-1-wsa+renesas@sang-engineering.com> <20200210172929.6001-2-wsa+renesas@sang-engineering.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Mon, 10 Feb 2020 18:29:25 +0100, Wolfram Sang wrote: > Only few drivers use this call, so drivers and I2C core are converted at > once with this patch. By simply using i2c_new_client_device() instead of > i2c_new_device(), we easily can return an ERRPTR for this function as > well. To make out of tree users aware that something changed, the > function is renamed to i2c_install_smbus_alert(). I wouldn't bother renaming the function. Chances that there actually are out-of-tree users of this function are pretty small, and if that is the case, they can adjust their code easily in a way that is still compatible with old kernels. -- Jean Delvare SUSE L3 Support