From: Jiri Olsa <jolsa@redhat.com>
To: Kajol Jain <kjain@linux.ibm.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Jin Yao <yao.jin@linux.intel.com>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Anju T Sudhakar <anju@linux.vnet.ibm.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v4] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events
Date: Sun, 16 Feb 2020 21:21:43 +0100 [thread overview]
Message-ID: <20200216202143.GA145986@krava> (raw)
In-Reply-To: <20200212054102.9259-1-kjain@linux.ibm.com>
On Wed, Feb 12, 2020 at 11:11:02AM +0530, Kajol Jain wrote:
SNIP
>
> return metric_events[0];
> @@ -160,6 +161,14 @@ static int metricgroup__setup_events(struct list_head *groups,
> int ret = 0;
> struct egroup *eg;
> struct evsel *evsel;
> + bool *evlist_used;
> +
> + evlist_used = (bool *)calloc(perf_evlist->core.nr_entries,
> + sizeof(bool));
> + if (!evlist_used) {
> + ret = -ENOMEM;
> + break;
hum, how did this compile for you? ;-)
util/metricgroup.c: In function ‘metricgroup__setup_events’:
util/metricgroup.c:170:3: error: break statement not within loop or switch
170 | break;
jirka
next prev parent reply other threads:[~2020-02-16 20:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 5:41 [PATCH v4] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events Kajol Jain
2020-02-16 20:21 ` Jiri Olsa [this message]
2020-02-18 5:57 ` kajoljain
2020-02-17 3:11 ` Joakim Zhang
2020-02-20 9:53 ` kajoljain
2020-02-20 10:36 ` Joakim Zhang
2020-03-02 6:14 ` kajoljain
2020-03-20 6:47 ` Joakim Zhang
2020-03-24 7:13 ` kajoljain
2020-03-24 8:00 ` [RFC] Issue in final aggregate value, in case of multiple events present in metric expression kajoljain
2020-05-09 5:52 ` Joakim Zhang
2020-05-11 0:56 ` Andi Kleen
2020-05-11 1:12 ` Jin, Yao
2020-05-11 2:05 ` Joakim Zhang
2020-05-13 8:08 ` Joakim Zhang
2020-03-02 1:17 ` [tools/perf/metricgroup] 5dd4f4ab07: stderr.mv:cannot_stat'util/.metricgroup.o.tmp':No_such_file_or_directory kernel test robot
2020-03-02 5:00 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216202143.GA145986@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox