Re: [Patch V5 03/21] phy: tegra: xusb: Add usb-role-switch support

Thierry Reding
2020-02-17T08:39:27Z

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

On Mon, Feb 10, 2020 at 01:41:29PM +0530, Nagarjuna Kristam wrote:
> If usb-role-switch property is present in USB 2 port, register
> usb-role-switch to receive usb role changes.
>
> Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
> ---
> V5
> - No changes
> ---
> V4:
> - Updated function name in debug messages as suggested by Thierry.
> - Added owner info to port->dev during USB role switch registration.
> ---
> V3:
> - Driver aborts if usb-role-switch is not added in dt forotg/peripheral
> roles.
> - Added role name strings instead of enum values in debug prints.
> - Updated arguments and variable allignments as per Thierry inputs.
> ---
> V2:
> - Removed dev_set_drvdata for port->dev.
> - Added of_platform_depopulate during error handling and driver removal.
> ---
> drivers/phy/tegra/Kconfig | 1 +
> drivers/phy/tegra/xusb.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++
> drivers/phy/tegra/xusb.h | 3 +++
> 3 files changed, 71 insertions(+)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]