From: Greg KH <gregkh@linuxfoundation.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: chanwoo@kernel.org, myungjoo.ham@samsung.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: Remove unneeded extern keyword from extcon-provider.h
Date: Mon, 17 Feb 2020 11:45:16 +0100 [thread overview]
Message-ID: <20200217104516.GA94720@kroah.com> (raw)
In-Reply-To: <20200217104728.29330-1-cw00.choi@samsung.com>
On Mon, Feb 17, 2020 at 07:47:28PM +0900, Chanwoo Choi wrote:
> The commit tb7365587f513 ("extcon: Remove unneeded extern keyword
> from extcon.h") removes the unneeded extern keyword from extcon header
> file. But, The commit tb7365587f513 has missed that deletes 'extern'
> keyword from extcon-provider.h. So that it deletes extern keyword
> from extcon-provider.h.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Dear Greg,
>
> When I removed the unneeded extern keyword from extcon hearder file for
> v5.6-rc1, although I should remove 'extern' keyword on both extcon.h
> and extcon-provider.h, I only removed them from extcon.h. It was my mistake.
>
> So that I send this patch for v5.6-rc3 release.
> Could you review and apply it to char-misc git repository directly?
Sure, but it's not really a bugfix, I'll queue it up for 5.7-rc1, ok?
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-17 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200217103927epcas1p2f0cf3c28dbc78d991ef8f4895e4717dd@epcas1p2.samsung.com>
2020-02-17 10:47 ` [PATCH] extcon: Remove unneeded extern keyword from extcon-provider.h Chanwoo Choi
2020-02-17 10:45 ` Greg KH [this message]
2020-02-17 11:05 ` Chanwoo Choi
2020-03-18 11:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217104516.GA94720@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox