[PATCH] extcon: Remove unneeded extern keyword from extcon-provider.h

[PATCH] extcon: Remove unneeded extern keyword from extcon-provider.h

[Chanwoo Choi]

The commit tb7365587f513 ("extcon: Remove unneeded extern keyword
from extcon.h") removes the unneeded extern keyword from extcon header
file. But, The commit tb7365587f513 has missed that deletes 'extern'
keyword from extcon-provider.h. So that it deletes extern keyword
from extcon-provider.h.

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
Dear Greg,

When I removed the unneeded extern keyword from extcon hearder file for
v5.6-rc1, although I should remove 'extern' keyword on both extcon.h
and extcon-provider.h, I only removed them from extcon.h. It was my mistake.

So that I send this patch for v5.6-rc3 release.
Could you review and apply it to char-misc git repository directly?

 include/linux/extcon-provider.h | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/include/linux/extcon-provider.h b/include/linux/extcon-provider.h
index 1c143d200caa..fa70945f4e6b 100644
--- a/include/linux/extcon-provider.h
+++ b/include/linux/extcon-provider.h
@@ -17,30 +17,30 @@ struct extcon_dev;
 #if IS_ENABLED(CONFIG_EXTCON)
 
 /* Following APIs register/unregister the extcon device. */
-extern int extcon_dev_register(struct extcon_dev *edev);
-extern void extcon_dev_unregister(struct extcon_dev *edev);
-extern int devm_extcon_dev_register(struct device *dev,
+int extcon_dev_register(struct extcon_dev *edev);
+void extcon_dev_unregister(struct extcon_dev *edev);
+int devm_extcon_dev_register(struct device *dev,
 				struct extcon_dev *edev);
-extern void devm_extcon_dev_unregister(struct device *dev,
+void devm_extcon_dev_unregister(struct device *dev,
 				struct extcon_dev *edev);
 
 /* Following APIs allocate/free the memory of the extcon device. */
-extern struct extcon_dev *extcon_dev_allocate(const unsigned int *cable);
-extern void extcon_dev_free(struct extcon_dev *edev);
-extern struct extcon_dev *devm_extcon_dev_allocate(struct device *dev,
+struct extcon_dev *extcon_dev_allocate(const unsigned int *cable);
+void extcon_dev_free(struct extcon_dev *edev);
+struct extcon_dev *devm_extcon_dev_allocate(struct device *dev,
 				const unsigned int *cable);
-extern void devm_extcon_dev_free(struct device *dev, struct extcon_dev *edev);
+void devm_extcon_dev_free(struct device *dev, struct extcon_dev *edev);
 
 /* Synchronize the state and property value for each external connector. */
-extern int extcon_sync(struct extcon_dev *edev, unsigned int id);
+int extcon_sync(struct extcon_dev *edev, unsigned int id);
 
 /*
  * Following APIs set the connected state of each external connector.
  * The 'id' argument indicates the defined external connector.
  */
-extern int extcon_set_state(struct extcon_dev *edev, unsigned int id,
+int extcon_set_state(struct extcon_dev *edev, unsigned int id,
 				bool state);
-extern int extcon_set_state_sync(struct extcon_dev *edev, unsigned int id,
+int extcon_set_state_sync(struct extcon_dev *edev, unsigned int id,
 				bool state);
 
 /*
@@ -52,13 +52,13 @@ extern int extcon_set_state_sync(struct extcon_dev *edev, unsigned int id,
  * for each external connector. They are used to set the capability of the
  * property of each external connector based on the id and property.
  */
-extern int extcon_set_property(struct extcon_dev *edev, unsigned int id,
+int extcon_set_property(struct extcon_dev *edev, unsigned int id,
 				unsigned int prop,
 				union extcon_property_value prop_val);
-extern int extcon_set_property_sync(struct extcon_dev *edev, unsigned int id,
+int extcon_set_property_sync(struct extcon_dev *edev, unsigned int id,
 				unsigned int prop,
 				union extcon_property_value prop_val);
-extern int extcon_set_property_capability(struct extcon_dev *edev,
+int extcon_set_property_capability(struct extcon_dev *edev,
 				unsigned int id, unsigned int prop);
 
 #else /* CONFIG_EXTCON */
-- 
2.17.1

Re: [PATCH] extcon: Remove unneeded extern keyword from extcon-provider.h

[Greg KH]

On Mon, Feb 17, 2020 at 07:47:28PM +0900, Chanwoo Choi wrote:
> The commit tb7365587f513 ("extcon: Remove unneeded extern keyword
> from extcon.h") removes the unneeded extern keyword from extcon header
> file. But, The commit tb7365587f513 has missed that deletes 'extern'
> keyword from extcon-provider.h. So that it deletes extern keyword
> from extcon-provider.h.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Dear Greg,
> 
> When I removed the unneeded extern keyword from extcon hearder file for
> v5.6-rc1, although I should remove 'extern' keyword on both extcon.h
> and extcon-provider.h, I only removed them from extcon.h. It was my mistake.
> 
> So that I send this patch for v5.6-rc3 release.
> Could you review and apply it to char-misc git repository directly?

Sure, but it's not really a bugfix, I'll queue it up for 5.7-rc1, ok?

thanks,

greg k-h

Re: [PATCH] extcon: Remove unneeded extern keyword from extcon-provider.h

[Chanwoo Choi]

On 2/17/20 7:45 PM, Greg KH wrote:
> On Mon, Feb 17, 2020 at 07:47:28PM +0900, Chanwoo Choi wrote:
>> The commit tb7365587f513 ("extcon: Remove unneeded extern keyword
>> from extcon.h") removes the unneeded extern keyword from extcon header
>> file. But, The commit tb7365587f513 has missed that deletes 'extern'
>> keyword from extcon-provider.h. So that it deletes extern keyword
>> from extcon-provider.h.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> Dear Greg,
>>
>> When I removed the unneeded extern keyword from extcon hearder file for
>> v5.6-rc1, although I should remove 'extern' keyword on both extcon.h
>> and extcon-provider.h, I only removed them from extcon.h. It was my mistake.
>>
>> So that I send this patch for v5.6-rc3 release.
>> Could you review and apply it to char-misc git repository directly?
> 
> Sure, but it's not really a bugfix, I'll queue it up for 5.7-rc1, ok?

Right. It is not bugfix. Just This patch is related to patch[1]
which was merged to v5.6-rc1.
[1] commit tb7365587f513 ("extcon: Remove unneeded extern keyword
from extcon.h")

If you think that it is not needed to be merged for v5.6-rc3,
I think that it is better to apply it to extcon-next branch
for v5.7-rc1.


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Re: [PATCH] extcon: Remove unneeded extern keyword from extcon-provider.h

[Greg KH]

On Mon, Feb 17, 2020 at 08:05:40PM +0900, Chanwoo Choi wrote:
> On 2/17/20 7:45 PM, Greg KH wrote:
> > On Mon, Feb 17, 2020 at 07:47:28PM +0900, Chanwoo Choi wrote:
> >> The commit tb7365587f513 ("extcon: Remove unneeded extern keyword
> >> from extcon.h") removes the unneeded extern keyword from extcon header
> >> file. But, The commit tb7365587f513 has missed that deletes 'extern'
> >> keyword from extcon-provider.h. So that it deletes extern keyword
> >> from extcon-provider.h.
> >>
> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> >> ---
> >> Dear Greg,
> >>
> >> When I removed the unneeded extern keyword from extcon hearder file for
> >> v5.6-rc1, although I should remove 'extern' keyword on both extcon.h
> >> and extcon-provider.h, I only removed them from extcon.h. It was my mistake.
> >>
> >> So that I send this patch for v5.6-rc3 release.
> >> Could you review and apply it to char-misc git repository directly?
> > 
> > Sure, but it's not really a bugfix, I'll queue it up for 5.7-rc1, ok?
> 
> Right. It is not bugfix. Just This patch is related to patch[1]
> which was merged to v5.6-rc1.
> [1] commit tb7365587f513 ("extcon: Remove unneeded extern keyword
> from extcon.h")
> 
> If you think that it is not needed to be merged for v5.6-rc3,
> I think that it is better to apply it to extcon-next branch
> for v5.7-rc1.

I'll queue this up for 5.7-rc1, thanks.

greg k-h