Re: [PATCH V3 2/2] drivers: input: keyboard: add mtk keypad driver

Andy Shevchenko
2020-02-18T15:51:52Z

On Tue, Feb 18, 2020 at 04:14:24PM +0100, Fabien Parent wrote:
> On Tue, Jan 14, 2020 at 1:39 PM fengping.yu <fengping.yu@mediatek.com> wrote:

...

> > +#define KP_STA 0x0000
> > +#define KP_MEM1 0x0004
> > +#define KP_MEM2 0x0008
> > +#define KP_MEM3 0x000c
> > +#define KP_MEM4 0x0010
> > +#define KP_MEM5 0x0014
> > +#define KP_DEBOUNCE 0x0018
> > +#define KP_SEL 0x0020
> > +#define KP_EN 0x0024

...

> > +#define KPD_NUM_MEMS 5
> > +#define KPD_MEM5_BITS 8
> > +#define KPD_NUM_KEYS 72 /* 4 * 16 + KPD_MEM5_BITS */

> > + kpd_get_keymap_state(keypad->base, new_state);
>
> kpd_get_keymap_state(keypad->base + KP_MEM1, new_state);

Why?

--
With Best Regards,
Andy Shevchenko