* [PATCH] tmpfs: deny and force are not huge mount options
@ 2020-02-18 4:04 Hugh Dickins
2020-02-18 20:07 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2020-02-18 4:04 UTC (permalink / raw)
To: Al Viro; +Cc: linux-kernel
5.6-rc1 commit 2710c957a8ef ("fs_parse: get rid of ->enums") regressed
the huge tmpfs mount options to an earlier state: "deny" and "force"
are not valid there, and can crash the kernel. Delete those lines.
Signed-off-by: Hugh Dickins <hughd@google.com>
---
mm/shmem.c | 2 --
1 file changed, 2 deletions(-)
--- 5.6-rc2/mm/shmem.c 2020-02-09 17:36:41.798976778 -0800
+++ linux/mm/shmem.c 2020-02-17 19:27:22.704093986 -0800
@@ -3386,8 +3386,6 @@ static const struct constant_table shmem
{"always", SHMEM_HUGE_ALWAYS },
{"within_size", SHMEM_HUGE_WITHIN_SIZE },
{"advise", SHMEM_HUGE_ADVISE },
- {"deny", SHMEM_HUGE_DENY },
- {"force", SHMEM_HUGE_FORCE },
{}
};
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tmpfs: deny and force are not huge mount options
2020-02-18 4:04 [PATCH] tmpfs: deny and force are not huge mount options Hugh Dickins
@ 2020-02-18 20:07 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2020-02-18 20:07 UTC (permalink / raw)
To: Hugh Dickins; +Cc: linux-kernel
On Mon, Feb 17, 2020 at 08:04:19PM -0800, Hugh Dickins wrote:
> 5.6-rc1 commit 2710c957a8ef ("fs_parse: get rid of ->enums") regressed
> the huge tmpfs mount options to an earlier state: "deny" and "force"
> are not valid there, and can crash the kernel. Delete those lines.
Applied to #fixes, will send to Linus tonight.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-18 20:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-18 4:04 [PATCH] tmpfs: deny and force are not huge mount options Hugh Dickins
2020-02-18 20:07 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).