Re: [PATCH v6 02/19] mm: Ignore return value of ->readpages

John Hubbard
2020-02-18T21:33:23Z

On 2/17/20 10:45 AM, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> We used to assign the return value to a variable, which we then ignored.
> Remove the pretence of caring.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> mm/readahead.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)

Looks good,

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
--
John Hubbard
NVIDIA

>
> diff --git a/mm/readahead.c b/mm/readahead.c
> index 8ce46d69e6ae..12d13b7792da 100644
> --- a/mm/readahead.c
> +++ b/mm/readahead.c
> @@ -113,17 +113,16 @@ int read_cache_pages(struct address_space *mapping, struct list_head *pages,
>
> EXPORT_SYMBOL(read_cache_pages);
>
> -static int read_pages(struct address_space *mapping, struct file *filp,
> +static void read_pages(struct address_space *mapping, struct file *filp,
> struct list_head *pages, unsigned int nr_pages, gfp_t gfp)
> {
> struct blk_plug plug;
> unsigned page_idx;
> - int ret;
>
> blk_start_plug(&plug);
>
> if (mapping->a_ops->readpages) {
> - ret = mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
> + mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
> /* Clean up the remaining pages */
> put_pages_list(pages);
> goto out;
> @@ -136,12 +135,9 @@ static int read_pages(struct address_space *mapping, struct file *filp,
> mapping->a_ops->readpage(filp, page);
> put_page(page);
> }
> - ret = 0;
>
> out:
> blk_finish_plug(&plug);
> -
> - return ret;
> }
>
> /*
>