From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CF7C3404D for ; Wed, 19 Feb 2020 03:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E23E24670 for ; Wed, 19 Feb 2020 03:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582082978; bh=Be/ShAdVvoVw7PIhz4RQ5k4za6c4aizt0SASf/qexgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Il55AJO9faqMvN0nKa5FYQV+BQsPTNfnjYvJPnDloMTepSjo2FJ1ItOA8T+Xz9r7M KfZsTu1nePi5vTndLg/IgQNJZGNJf+DfUZRlmnKRnb7yvuc2MCxDJnn926+JT3Lmhb 9LbOk6iEjPNNrmVbjjD2jvIxiE3R91K8BYDqsEWU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbgBSD3h (ORCPT ); Tue, 18 Feb 2020 22:29:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:41670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbgBSD3g (ORCPT ); Tue, 18 Feb 2020 22:29:36 -0500 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB6A824658; Wed, 19 Feb 2020 03:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582082976; bh=Be/ShAdVvoVw7PIhz4RQ5k4za6c4aizt0SASf/qexgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=plo0B7tNDe57VbC/yC0rOzcAei0YUXdc1f4dr2CWVcw7e0qg9AgP+rj6qu8UrLaSF gewq1595Ti6GJCQLWG0bqUD0ydY7Gq+C+nxwRKtF05o+5dxf/CzPCrGZ495V+t6U4e Fy0nGJuZP4V+WRQbsVvNFY4o4dZo13ulK1XTogiE= Date: Tue, 18 Feb 2020 19:29:34 -0800 From: Eric Biggers To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH v6 14/19] ext4: Convert from readpages to readahead Message-ID: <20200219032934.GC1075@sol.localdomain> References: <20200217184613.19668-1-willy@infradead.org> <20200217184613.19668-25-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217184613.19668-25-willy@infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 17, 2020 at 10:46:05AM -0800, Matthew Wilcox wrote: > diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c > index c1769afbf799..e14841ade612 100644 > --- a/fs/ext4/readpage.c > +++ b/fs/ext4/readpage.c > @@ -7,8 +7,8 @@ > * > * This was originally taken from fs/mpage.c > * > - * The intent is the ext4_mpage_readpages() function here is intended > - * to replace mpage_readpages() in the general case, not just for > + * The ext4_mpage_readahead() function here is intended to > + * replace mpage_readahead() in the general case, not just for > * encrypted files. It has some limitations (see below), where it > * will fall back to read_block_full_page(), but these limitations > * should only be hit when page_size != block_size. > @@ -222,8 +222,7 @@ static inline loff_t ext4_readpage_limit(struct inode *inode) > } This says ext4_mpage_readahead(), but it's actually still called ext4_mpage_readpages(). - Eric