From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH RESEND 1/2] regulator: arizona-ldo1: Improve handling of regulator unbinding
Date: Wed, 19 Feb 2020 12:31:30 +0000 [thread overview]
Message-ID: <20200219123130.GE3494@dell> (raw)
In-Reply-To: <20200123120240.GD4098@ediswmail.ad.cirrus.com>
On Thu, 23 Jan 2020, Charles Keepax wrote:
> On Thu, Jan 23, 2020 at 11:48:05AM +0000, Mark Brown wrote:
> > On Thu, Jan 23, 2020 at 09:26:39AM +0000, Charles Keepax wrote:
> >
> > > 3) We could look at doing something in regmap IRQ to change when
> > > it does PM runtime calls, it is regmap doing runtime gets when
> > > drivers remove IRQs that causes the issue. But my accessment was
> > > that what regmap is doing makes perfect sense, so I don't think
> > > this is a good approach.
> >
> > Why do you even care about the errors? It's not like this device is
> > going to get removed in a production system and the primary IRQ will be
> > disabled when the core is removed, this is just something that happens
> > during development isn't it?
>
> I am more than happy to do the leg work if we really don't like
> this solution. Do either you or Lee have any thoughts on my
> selective MFD remove helpers? That seemed like the most promising
> alternative solution to me.
It's hard to say without seeing your implementation, but it sounds
okay in principle. Depends how messy it all ends up getting. Sounds
like a scenario where a reverse -EDEFER_PROBE could be useful.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-02-19 12:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 11:08 [PATCH RESEND 1/2] regulator: arizona-ldo1: Improve handling of regulator unbinding Charles Keepax
2020-01-22 11:08 ` [PATCH RESEND 2/2] mfd: madera: " Charles Keepax
2020-01-22 13:11 ` [PATCH RESEND 1/2] regulator: arizona-ldo1: " Mark Brown
2020-01-23 9:26 ` Charles Keepax
2020-01-23 11:48 ` Mark Brown
2020-01-23 12:02 ` Charles Keepax
2020-01-23 12:09 ` Mark Brown
2020-02-19 12:31 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219123130.GE3494@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox