From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kaaira Gupta <kgupta@es.iitr.ac.in>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: change CamelCase to CAPS
Date: Wed, 19 Feb 2020 19:46:16 +0100 [thread overview]
Message-ID: <20200219184616.GA2854654@kroah.com> (raw)
In-Reply-To: <20200219174646.GA27559@kaaira-HP-Pavilion-Notebook>
On Wed, Feb 19, 2020 at 11:16:46PM +0530, Kaaira Gupta wrote:
> fix checkpatch.pl check of 'Avoid CamelCase' by changing NI_CtrSource to
> NI_CTRSOURCE in all the files. Change it to CAPS because it is a MICRO
What is a "MICRO"?
> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
Are you sure this is ok? I think this comes directly from a spec sheet
so changing it might not be good.
as proof:
> @@ -104,7 +104,7 @@ struct ni_device_routes ni_pci_6070e_device_routes = {
> {
> .dest = TRIGGER_LINE(0),
> .src = (int[]){
> - NI_CtrSource(0),
> + NI_CTRSOURCE(0),
> NI_CtrGate(0),
> NI_CtrInternalOutput(0),
> NI_CtrOut(0),
Looks like all of these are CamelCase, why are you changing only one?
They all should be the same, and odds are, how they are today is fine,
right?
Look at the git history of these files to be sure.
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-19 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 17:46 [PATCH] staging: comedi: change CamelCase to CAPS Kaaira Gupta
2020-02-19 18:46 ` Greg Kroah-Hartman [this message]
2020-02-19 18:47 ` Greg Kroah-Hartman
2020-02-19 19:31 ` Kaaira Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219184616.GA2854654@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=hsweeten@visionengravers.com \
--cc=kgupta@es.iitr.ac.in \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox