From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Lee Jones <lee.jones@linaro.org>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com,
mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz,
agx@sigxcpu.org, daniel.thompson@linaro.org,
jingoohan1@gmail.com, dri-devel@lists.freedesktop.org,
tomi.valkeinen@ti.com, jjhiblot@ti.com
Subject: Re: [PATCH] backlight: add led-backlight driver
Date: Wed, 19 Feb 2020 13:15:13 -0800 [thread overview]
Message-ID: <20200219211513.GE37466@atomide.com> (raw)
In-Reply-To: <20200219205322.GA1227@duo.ucw.cz>
* Pavel Machek <pavel@ucw.cz> [200219 20:54]:
> Hi!
>
> > > This patch adds a led-backlight driver (led_bl), which is similar to
> > > pwm_bl except the driver uses a LED class driver to adjust the
> > > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > >
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > > Acked-by: Lee Jones <lee.jones@linaro.org>
> > > Acked-by: Tony Lindgren <tony@atomide.com>
> > > Tested-by: Tony Lindgren <tony@atomide.com>
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > ---
> > > drivers/video/backlight/Kconfig | 7 ++
> > > drivers/video/backlight/Makefile | 1 +
> > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 268 insertions(+)
> > > create mode 100644 drivers/video/backlight/led_bl.c
>
> > > Here's the version of the driver I have. AFAICT
> > > default-brightness-level handling is ok, so does not need to be
> > > changed.
> > >
> > > Lee, it would be easiest for me if you could apply it to your tree and
> > > push, but given enough time I can push it to Linus, too.
> >
> > Oh you're using quoted-printable for patches.. Got it applied now,
> > and it still works. Below is also the related dts change that
> > I tested with.
> >
> > Feel free to pick the dts change too, naturally that should
> > not be applied before the driver.
> >
> > If you guys instead want me to pick these both into my fixes
> > branch, just let me know and I'll do the explaining why these
> > are needed as fixes. Basically we no longer have a way to enable
> > the LCD backlight for droid4 manually starting with v5.6-rc1
> > unlike earlier.
>
> If you are willing to do that, it looks like good solution from my
> point of view.
OK. I'll apply them but won't push out yet in case Lee is already
applying the driver change..
Pavel, care to ack the dts patch?
Regards,
Tony
next prev parent reply other threads:[~2020-02-19 21:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 19:14 [PATCH] backlight: add led-backlight driver Pavel Machek
2020-02-19 19:45 ` Tony Lindgren
2020-02-19 20:53 ` Pavel Machek
2020-02-19 21:15 ` Tony Lindgren [this message]
2020-02-19 23:54 ` Pavel Machek
2020-02-19 23:44 ` Sebastian Reichel
2020-02-20 14:54 ` Tony Lindgren
2020-02-20 7:48 ` Lee Jones
2020-02-20 15:09 ` Tony Lindgren
2020-02-20 8:29 ` Guido Günther
2020-02-20 23:41 ` Camera LED on Librem 5 was " Pavel Machek
2020-08-14 17:23 ` Guido Günther
2020-08-23 21:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219211513.GE37466@atomide.com \
--to=tony@atomide.com \
--cc=agx@sigxcpu.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=jjhiblot@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=martin_rysavy@centrum.cz \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).