From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F38C7619D for ; Thu, 20 Feb 2020 00:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC35D208C4 for ; Thu, 20 Feb 2020 00:31:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x6gNshAS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727161AbgBTAb4 (ORCPT ); Wed, 19 Feb 2020 19:31:56 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:35502 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727046AbgBTAb4 (ORCPT ); Wed, 19 Feb 2020 19:31:56 -0500 Received: by mail-pg1-f194.google.com with SMTP id v23so986514pgk.2 for ; Wed, 19 Feb 2020 16:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nh/PXJt5LIK6knlDEBV+szof//jRNZ6d+fFEe23/31U=; b=x6gNshASw2xBuVQruMd2+i0AlOaA3fYhjwWuGLZwAM7FObTbKD0cIU7WwozKq5LG9N QKe9K0IhRl08tPACnnQqAKOjsAP0EKLwMIAAeFNX2Hqyfvw7ZwVtdqkytJgJfm05KkkU vr+c3vvs34c/xw+v9D5qMrCQTjnyAFfRmsWviBm5E/xCjJm0Jvl8XsAwc1dricxMw+Lh upktjdIBtqcUH1E7t80m8dTkzVHqMqBoiQ3tgZ8lvNovnpIuzSMNmUo1maXZzESmZFxB 5npZjsYrYatMHb+gEJLgHK9gx5nHlf9LGlzzGapKcmhf8UMyBdHYl7cBOl1diX66k54k K6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nh/PXJt5LIK6knlDEBV+szof//jRNZ6d+fFEe23/31U=; b=IO+zmcxzrX9LhpTxBbhdRMCbN4rM0rZuurM05lq8niCoP7ONYZglz7yLAx2O/QSwdG mSBaYyJEzsqiagPO5E/IjqjDMH13cuYfG0pmkHqLHEBr5HO9MqAyG+AzSpb81wYhwUQ9 ZM86j6XzvrYdltgHQNRVnRhl/m5g3NE23fVpiicdj9IRGnQsUohyFhtGKMIouZNoA2mz onWFNL3LTarIJc6z2voXdMnJLPKyTyKqi7tQMv02MM8KiVbdhisfCBu1u+mmli5qiKs7 UWLFDTeT5ZPEbo8G7ESTbAHCHxAVSq/XSnR4Hvg57HEvB1eGeR5xQ//K+XUBIg0GzcmF i3Dw== X-Gm-Message-State: APjAAAUN5PjhQ0p7DlbGPjfFnp6qayTEPxHmeE9Z6oJ/cJJBvlUPmmop o+8+thl5u+WQmsVqCN52RPaGVA== X-Google-Smtp-Source: APXvYqxoGLXHiH+nbn5V/5/GaH/0ND+3nZ09GJR+kv3Z8JEcxf2VsZSpJjwFzPRRtnBZkQZ+r9FL6w== X-Received: by 2002:a63:7417:: with SMTP id p23mr29631359pgc.277.1582158715148; Wed, 19 Feb 2020 16:31:55 -0800 (PST) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id t186sm866470pgd.26.2020.02.19.16.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 16:31:54 -0800 (PST) Date: Wed, 19 Feb 2020 16:31:52 -0800 From: Bjorn Andersson To: Stephen Boyd Cc: Wim Van Sebroeck , Guenter Roeck , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, Andy Gross , Sai Prakash Ranjan Subject: Re: [PATCH] watchdog: qcom: Use irq flags from firmware Message-ID: <20200220003152.GC99370@yoga> References: <20200220002047.115000-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220002047.115000-1-swboyd@chromium.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 19 Feb 16:20 PST 2020, Stephen Boyd wrote: > The DT or ACPI tables should tell the driver what the irq flags are. > Given that this driver probes only on DT based platforms and those DT > platforms specify the irq flags we can safely drop the forced irq flag > setting here. > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Sai Prakash Ranjan Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Stephen Boyd > --- > drivers/watchdog/qcom-wdt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > index eb47fe5ed280..c70e89013101 100644 > --- a/drivers/watchdog/qcom-wdt.c > +++ b/drivers/watchdog/qcom-wdt.c > @@ -248,8 +248,7 @@ static int qcom_wdt_probe(struct platform_device *pdev) > /* check if there is pretimeout support */ > irq = platform_get_irq_optional(pdev, 0); > if (irq > 0) { > - ret = devm_request_irq(dev, irq, qcom_wdt_isr, > - IRQF_TRIGGER_RISING, > + ret = devm_request_irq(dev, irq, qcom_wdt_isr, 0, > "wdt_bark", &wdt->wdd); > if (ret) > return ret; > -- > Sent by a computer, using git, on the internet >