From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Ram Chandra Jangir <rjangir@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipq8064: pinctrl: Fixed missing RGMII pincontrol definitions
Date: Wed, 19 Feb 2020 22:54:59 -0800 [thread overview]
Message-ID: <20200220065459.GE99370@yoga> (raw)
In-Reply-To: <20200219175940.744-1-ansuelsmth@gmail.com>
On Wed 19 Feb 09:59 PST 2020, Ansuel Smith wrote:
> Add missing gpio definition for mdio and rgmii2.
>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Ram Chandra Jangir <rjangir@codeaurora.org>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/pinctrl/qcom/pinctrl-ipq8064.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq8064.c b/drivers/pinctrl/qcom/pinctrl-ipq8064.c
> index c2fb1ddf2f22..ac717ee38416 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq8064.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq8064.c
> @@ -299,7 +299,7 @@ static const char * const gpio_groups[] = {
> };
>
> static const char * const mdio_groups[] = {
> - "gpio0", "gpio1", "gpio10", "gpio11",
> + "gpio0", "gpio1", "gpio2", "gpio10", "gpio11", "gpio66",
> };
>
> static const char * const mi2s_groups[] = {
> @@ -403,8 +403,8 @@ static const char * const usb2_hsic_groups[] = {
> };
>
> static const char * const rgmii2_groups[] = {
> - "gpio27", "gpio28", "gpio29", "gpio30", "gpio31", "gpio32",
> - "gpio51", "gpio52", "gpio59", "gpio60", "gpio61", "gpio62",
> + "gpio2", "gpio27", "gpio28", "gpio29", "gpio30", "gpio31", "gpio32",
> + "gpio51", "gpio52", "gpio59", "gpio60", "gpio61", "gpio62", "gpio66",
> };
>
> static const char * const sata_groups[] = {
> @@ -539,7 +539,7 @@ static const struct msm_function ipq8064_functions[] = {
> static const struct msm_pingroup ipq8064_groups[] = {
> PINGROUP(0, mdio, NA, NA, NA, NA, NA, NA, NA, NA, NA),
> PINGROUP(1, mdio, NA, NA, NA, NA, NA, NA, NA, NA, NA),
> - PINGROUP(2, gsbi5_spi_cs3, NA, NA, NA, NA, NA, NA, NA, NA, NA),
> + PINGROUP(2, gsbi5_spi_cs3, rgmii2, mdio, NA, NA, NA, NA, NA, NA, NA),
> PINGROUP(3, pcie1_rst, pcie1_prsnt, pdm, NA, NA, NA, NA, NA, NA, NA),
> PINGROUP(4, pcie1_pwren_n, pcie1_pwren, NA, NA, NA, NA, NA, NA, NA, NA),
> PINGROUP(5, pcie1_clk_req, pcie1_pwrflt, NA, NA, NA, NA, NA, NA, NA, NA),
> @@ -603,7 +603,7 @@ static const struct msm_pingroup ipq8064_groups[] = {
> PINGROUP(63, pcie3_rst, NA, NA, NA, NA, NA, NA, NA, NA, NA),
> PINGROUP(64, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA),
> PINGROUP(65, pcie3_clk_req, NA, NA, NA, NA, NA, NA, NA, NA, NA),
> - PINGROUP(66, NA, NA, NA, NA, NA, NA, NA, NA, NA, NA),
> + PINGROUP(66, rgmii2, mdio, NA, NA, NA, NA, NA, NA, NA, NA),
> PINGROUP(67, usb2_hsic, NA, NA, NA, NA, NA, NA, NA, NA, NA),
> PINGROUP(68, usb2_hsic, NA, NA, NA, NA, NA, NA, NA, NA, NA),
> SDC_PINGROUP(sdc3_clk, 0x204a, 14, 6),
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-02-20 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 17:59 [PATCH] ipq8064: pinctrl: Fixed missing RGMII pincontrol definitions Ansuel Smith
2020-02-20 6:54 ` Bjorn Andersson [this message]
2020-02-21 15:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220065459.GE99370@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjangir@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox