From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 628DDC11D00 for ; Thu, 20 Feb 2020 07:48:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39F97208C4 for ; Thu, 20 Feb 2020 07:48:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jMbZPFgA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726976AbgBTHs0 (ORCPT ); Thu, 20 Feb 2020 02:48:26 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41593 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726764AbgBTHsZ (ORCPT ); Thu, 20 Feb 2020 02:48:25 -0500 Received: by mail-wr1-f66.google.com with SMTP id c9so3435164wrw.8 for ; Wed, 19 Feb 2020 23:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=D7/ilOTv/yfu8Ewt4axgtGDzooZ+foxh4W/MQRjliDM=; b=jMbZPFgAztkpn/Loio4h8rIr0dDunFm7z6lTmGUQtV5OJrvz92wbttJ/+tMh8NowL2 z1vThmc3N71RgnHF2+g5tJWWOdEsN4mp5kowlGnMiCD73SOu47thpDOMDGL701pUi5aP ryZN4nJLqy7fpegqQeTnLcP4zK0Nf8lysNGi6+569kWsh1Q4kXWMG5Ujv2+fD/U6sq3P hH5UD9uG3vxYW5fhUP7Ew97APi3TU6OakDzhqdgDf7ExXffBeuYg09pk5uXU6x26uAYX HeBk4GGYaDVxODy/6shfrytrKglqKSrWfHtdQGvW2lstWoKJApx+P3W5W9ayhiRUBZec kouw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=D7/ilOTv/yfu8Ewt4axgtGDzooZ+foxh4W/MQRjliDM=; b=iMyq+oH6EuoMZWEhJ6QmG7Mz5hq7udwa6KnsFYQYHgZJrHxPip/WXsHzMEOcJkkOSM I0ny/1Et0ZEB6Cw2De1OawFY5Hbmwxl4IIQMN3k1Q4fv8wQBmQXhmEDxgojnhnoOoOTg qc4oLl3zMAuBkVdOkgbltAfRLPcdMPcC2UvInuTND0yCL/4xPW2U97ACcg7MEqjs0hSu yE/tdDNCi4YGm+XWUliaCXEJURrWgPfG0NHQ4rYh83+0ZFJnBK8wC9QxVgVRvKp0LNxR aqbjlvHUjJ4M0/iXGYc/rIUuKDq/g+NH1MZQ7Z5zvzijABSCrd3MWXkV2s7SzFtKl5MH yjSQ== X-Gm-Message-State: APjAAAX1N94gnoy1edIyptcEbWS9vumt9JZf8Nafnihm8gFzmp38o78Y NmpQLWuPDCxehheJb+bWHRgpaQ== X-Google-Smtp-Source: APXvYqzdP9CBfyqkStiBpbb7vc3kk+lFEglaLS3RelisPlykfjRR3shD5qopiw1lOITr4YUmZpWffw== X-Received: by 2002:adf:f787:: with SMTP id q7mr40744149wrp.297.1582184902510; Wed, 19 Feb 2020 23:48:22 -0800 (PST) Received: from dell ([2.31.163.122]) by smtp.gmail.com with ESMTPSA id t187sm3571099wmt.25.2020.02.19.23.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 23:48:21 -0800 (PST) Date: Thu, 20 Feb 2020 07:48:49 +0000 From: Lee Jones To: Tony Lindgren Cc: Pavel Machek , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz, agx@sigxcpu.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, jjhiblot@ti.com Subject: Re: [PATCH] backlight: add led-backlight driver Message-ID: <20200220074849.GF3494@dell> References: <20200219191412.GA15905@amd> <20200219194540.GD37466@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200219194540.GD37466@atomide.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Feb 2020, Tony Lindgren wrote: > * Pavel Machek [200219 19:15]: > > From: Tomi Valkeinen > > > > This patch adds a led-backlight driver (led_bl), which is similar to > > pwm_bl except the driver uses a LED class driver to adjust the > > brightness in the HW. Multiple LEDs can be used for a single backlight. > > > > Signed-off-by: Tomi Valkeinen > > Signed-off-by: Jean-Jacques Hiblot > > Acked-by: Pavel Machek > > Reviewed-by: Daniel Thompson > > Acked-by: Lee Jones > > Acked-by: Tony Lindgren > > Tested-by: Tony Lindgren > > Signed-off-by: Pavel Machek > > --- > > drivers/video/backlight/Kconfig | 7 ++ > > drivers/video/backlight/Makefile | 1 + > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 268 insertions(+) > > create mode 100644 drivers/video/backlight/led_bl.c > > > > Hi! > > > > Here's the version of the driver I have. AFAICT > > default-brightness-level handling is ok, so does not need to be > > changed. > > > > Lee, it would be easiest for me if you could apply it to your tree and > > push, but given enough time I can push it to Linus, too. > > Oh you're using quoted-printable for patches.. Got it applied now, > and it still works. Below is also the related dts change that > I tested with. > > Feel free to pick the dts change too, naturally that should > not be applied before the driver. > > If you guys instead want me to pick these both into my fixes > branch, just let me know and I'll do the explaining why these > are needed as fixes. Basically we no longer have a way to enable > the LCD backlight for droid4 manually starting with v5.6-rc1 > unlike earlier. Please do. You already have my Ack. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog