From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C854C11D0B for ; Thu, 20 Feb 2020 15:09:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CF76208CD for ; Thu, 20 Feb 2020 15:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728465AbgBTPJG (ORCPT ); Thu, 20 Feb 2020 10:09:06 -0500 Received: from muru.com ([72.249.23.125]:56274 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728176AbgBTPJG (ORCPT ); Thu, 20 Feb 2020 10:09:06 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id DE1ED8080; Thu, 20 Feb 2020 15:09:48 +0000 (UTC) Date: Thu, 20 Feb 2020 07:09:01 -0800 From: Tony Lindgren To: Lee Jones Cc: Pavel Machek , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz, agx@sigxcpu.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, jjhiblot@ti.com Subject: Re: [PATCH] backlight: add led-backlight driver Message-ID: <20200220150901.GG37466@atomide.com> References: <20200219191412.GA15905@amd> <20200219194540.GD37466@atomide.com> <20200220074849.GF3494@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220074849.GF3494@dell> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lee Jones [200220 07:49]: > On Wed, 19 Feb 2020, Tony Lindgren wrote: > > > * Pavel Machek [200219 19:15]: > > > From: Tomi Valkeinen > > > > > > This patch adds a led-backlight driver (led_bl), which is similar to > > > pwm_bl except the driver uses a LED class driver to adjust the > > > brightness in the HW. Multiple LEDs can be used for a single backlight. > > > > > > Signed-off-by: Tomi Valkeinen > > > Signed-off-by: Jean-Jacques Hiblot > > > Acked-by: Pavel Machek > > > Reviewed-by: Daniel Thompson > > > Acked-by: Lee Jones > > > Acked-by: Tony Lindgren > > > Tested-by: Tony Lindgren > > > Signed-off-by: Pavel Machek > > > --- > > > drivers/video/backlight/Kconfig | 7 ++ > > > drivers/video/backlight/Makefile | 1 + > > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 268 insertions(+) > > > create mode 100644 drivers/video/backlight/led_bl.c > > > > > > Hi! > > > > > > Here's the version of the driver I have. AFAICT > > > default-brightness-level handling is ok, so does not need to be > > > changed. > > > > > > Lee, it would be easiest for me if you could apply it to your tree and > > > push, but given enough time I can push it to Linus, too. > > > > Oh you're using quoted-printable for patches.. Got it applied now, > > and it still works. Below is also the related dts change that > > I tested with. > > > > Feel free to pick the dts change too, naturally that should > > not be applied before the driver. > > > > If you guys instead want me to pick these both into my fixes > > branch, just let me know and I'll do the explaining why these > > are needed as fixes. Basically we no longer have a way to enable > > the LCD backlight for droid4 manually starting with v5.6-rc1 > > unlike earlier. > > Please do. You already have my Ack. OK pushed out these two patches in omap-for-v5.6/droid4-lcd-fix. Thanks, Tony