From: Peter Zijlstra <peterz@infradead.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux@rasmusvillemoes.dk, andriy.shevchenko@intel.com,
dan.j.williams@intel.com
Subject: Re: [PATCH v2 1/2] x86: fix bitops.h warning with a moved cast
Date: Thu, 20 Feb 2020 19:12:36 +0100 [thread overview]
Message-ID: <20200220181236.GC18400@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200220173722.2034546-1-jesse.brandeburg@intel.com>
On Thu, Feb 20, 2020 at 09:37:21AM -0800, Jesse Brandeburg wrote:
> Fix many sparse warnings when building with C=1.
>
> When the kernel is compiled with C=1, there are lots of messages like:
> arch/x86/include/asm/bitops.h:77:37: warning: cast truncates bits from constant value (ffffff7f becomes 7f)
>
> @@ -72,9 +74,11 @@ static __always_inline void
> arch_clear_bit(long nr, volatile unsigned long *addr)
> {
> if (__builtin_constant_p(nr)) {
> + u8 cmaski = ~CONST_MASK(nr);
> +
> asm volatile(LOCK_PREFIX "andb %1,%0"
> : CONST_MASK_ADDR(nr, addr)
> - : "iq" ((u8)~CONST_MASK(nr)));
> + : "iq" (cmaski));
> } else {
> asm volatile(LOCK_PREFIX __ASM_SIZE(btr) " %1,%0"
> : : RLONG_ADDR(addr), "Ir" (nr) : "memory");
Urgh, that's sad. So why doesn't this still generate a warning, ~ should
promote your u8 to int, and then you down-cast to u8 on assignment
again.
So now you have more lines, more ugly casts and exactly the same
generated code; where the win?
Perhaps you should write it like:
: "iq" (0xFF ^ CONST_MASK(nr))
hmm?
next prev parent reply other threads:[~2020-02-20 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 17:37 [PATCH v2 1/2] x86: fix bitops.h warning with a moved cast Jesse Brandeburg
2020-02-20 17:37 ` [PATCH v2 2/2] lib: make a test module with set/clear bit Jesse Brandeburg
2020-02-20 18:10 ` Peter Zijlstra
2020-02-20 19:03 ` Jesse Brandeburg
2020-02-20 18:12 ` Peter Zijlstra [this message]
2020-02-20 22:32 ` [PATCH v2 1/2] x86: fix bitops.h warning with a moved cast Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220181236.GC18400@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andriy.shevchenko@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).