Re: [PATCH 5.4 000/344] 5.4.22-stable review

Tero Kristo
2020-02-21T11:58:09Z

On 21/02/2020 13:17, Naresh Kamboju wrote:
> On Fri, 21 Feb 2020 at 15:34, Jon Hunter <jonathanh@nvidia.com> wrote:
>>
>>
>> On 21/02/2020 07:36, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.4.22 release.
>>> There are 344 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sun, 23 Feb 2020 07:19:49 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.22-rc1.gz
>>> or in the git tree and branch at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>> -------------
>>> Pseudo-Shortlog of commits:
>>
>> ...
>>
>>> Tero Kristo <t-kristo@ti.com>
>>> ARM: OMAP2+: pdata-quirks: add PRM data for reset support
>>
>>
>> The above commit is generating the following build error on ARM systems ...
>>
>> dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/mach-omap2/pdata-quirks.c:27:10: fatal error: linux/platform_data/ti-prm.h: No such file or directory
>> #include <linux/platform_data/ti-prm.h>
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> build error:
>
> ../arch/arm/mach-omap2/pdata-quirks.c:27:10: fatal error:
> linux/platform_data/ti-prm.h: No such file or directory
> 27 | #include <linux/platform_data/ti-prm.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[2]: *** [../scripts/Makefile.build:265:
> arch/arm/mach-omap2/pdata-quirks.o] Error 1
>
> With these below three patches, it applies cleanly and builds.
> But I'm not sure these are not expected to get into stable rc 5.4 branch.

Yeah, without PRM driver the pdata-quirk patch should not have been
picked up. I wonder why it ended up in stable. Tony, any ideas?

-Tero

>
> 3e99cb214f03 ("soc: ti: add initial PRM driver with reset control support")
> c5117a78dd88 ("soc: ti: omap-prm: poll for reset complete during de-assert")
> d30cd83f6853 ("soc: ti: omap-prm: add support for denying idle for
> reset clockdomain")
>
> However, it's only patch
> d30cd83f6853 ("soc: ti: omap-prm: add support for denying idle for
> reset clockdomain")
> that introduces file linux/platform_data/ti-prm.h
>
> --
> Linaro LKFT
> https://lkft.linaro.org
>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki