Re: [PATCH 5.4 000/344] 5.4.22-stable review

Guenter Roeck
2020-02-21T15:55:11Z

On Fri, Feb 21, 2020 at 03:21:30PM +0000, Ben Hutchings wrote:
> On Fri, 2020-02-21 at 06:28 -0800, Guenter Roeck wrote:
> [...]
> > Building powerpc:defconfig ... failed
> > Building powerpc:mpc83xx_defconfig ... failed
> > --------------
> > Error log:
> > drivers/rtc/rtc-ds1307.c:1570:21: error: variable 'regmap_config' has initializer but incomplete type
> >
> > as well as various follow-up errors.
> >
> > The second problem affects both v5.4.y and v5.5.y.
>
> This seems to be caused by commit 34719de919af (rtc-i2c-spi-avoid-
> inclusion-of-regmap-support-when-n.patch). These branches will need
> commit 578c2b661e2b "rtc: Kconfig: select REGMAP_I2C when necessary" as
> well.
>

Yes, I recall we had the same problem before, and the offending patch
was removed from the queue. Wonder how it made it back in without the
context patch (which either you or someone else also reported at the time).

Guenter