From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Saravana Kannan <saravanak@google.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Android Kernel Team <kernel-team@android.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] driver core: Call sync_state() even if supplier has no consumers
Date: Fri, 21 Feb 2020 11:32:33 +0100 [thread overview]
Message-ID: <20200221103233.GA101069@kroah.com> (raw)
In-Reply-To: <CAGETcx_yQZtU4O2KgMxVt-hSJCBtNsOpyWsSXc+OZcjjJ91M3g@mail.gmail.com>
On Fri, Feb 21, 2020 at 01:48:49AM -0800, Saravana Kannan wrote:
> On Fri, Feb 21, 2020 at 1:25 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Feb 21, 2020 at 12:05:08AM -0800, Saravana Kannan wrote:
> > > The initial patch that added sync_state() support didn't handle the case
> > > where a supplier has no consumers. This was because when a device is
> > > successfully bound with a driver, only its suppliers were checked to see
> > > if they are eligible to get a sync_state(). This is not sufficient for
> > > devices that have no consumers but still need to do device state clean
> > > up. So fix this.
> > >
> > > Fixes: fc5a251d0fd7ca90 (driver core: Add sync_state driver/bus callback)
> >
> > Should be:
> > Fixes: fc5a251d0fd7 ("driver core: Add sync_state driver/bus callback")
>
> Sorry, late night sleepy patches are never good!
> Btw I thought the sha should be only 12 characters but then saw
> another instance where you used 16 chars. What's the right one?
I used 16 chars? 12 should be all that is needed.
> > > Signed-off-by: Saravana Kannan <saravanak@google.com>
> >
> > So this needs to go to 5.5 also, right?
>
> Did you mean 5.4? Yes.
fc5a251d0fd7 is only in 5.5, not 5.4 from what I can see, right?
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-21 10:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 8:05 [PATCH v2 0/3] driver core: sync state fixups Saravana Kannan
2020-02-21 8:05 ` [PATCH v2 1/3] driver core: Call sync_state() even if supplier has no consumers Saravana Kannan
2020-02-21 9:25 ` Greg Kroah-Hartman
2020-02-21 9:48 ` Saravana Kannan
2020-02-21 10:32 ` Greg Kroah-Hartman [this message]
2020-02-21 16:00 ` Saravana Kannan
2020-02-21 8:05 ` [PATCH v2 2/3] driver core: Add dev_has_sync_state() Saravana Kannan
2020-02-21 8:05 ` [PATCH v2 3/3] driver core: Skip unnecessary work when device doesn't have sync_state() Saravana Kannan
2020-03-24 20:03 ` Davide Caratti
2020-03-24 20:14 ` Saravana Kannan
2020-03-25 7:44 ` Greg Kroah-Hartman
2020-03-25 9:11 ` Davide Caratti
2020-03-25 9:17 ` Greg Kroah-Hartman
2020-03-04 12:49 ` [PATCH v2 0/3] driver core: sync state fixups Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221103233.GA101069@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox