From: Guenter Roeck <linux@roeck-us.net>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: wim@linux-watchdog.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH 3/3] watchdog: imx2_wdt: Remove unused include of init.h
Date: Sat, 22 Feb 2020 08:02:18 -0800 [thread overview]
Message-ID: <20200222160218.GA12740@roeck-us.net> (raw)
In-Reply-To: <1582250430-8872-3-git-send-email-Anson.Huang@nxp.com>
On Fri, Feb 21, 2020 at 10:00:30AM +0800, Anson Huang wrote:
> There is nothing in use from init.h, remove it.
>
NACK, sorry; this driver uses __init and __exit_p.
Guenter
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/watchdog/imx2_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
> index f8d58bf..ce28e40 100644
> --- a/drivers/watchdog/imx2_wdt.c
> +++ b/drivers/watchdog/imx2_wdt.c
> @@ -20,7 +20,6 @@
>
> #include <linux/clk.h>
> #include <linux/delay.h>
> -#include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/kernel.h>
next prev parent reply other threads:[~2020-02-22 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 2:00 [PATCH 1/3] watchdog: imx_sc_wdt: Remove unused includes Anson Huang
2020-02-21 2:00 ` [PATCH 2/3] watchdog: imx7ulp: Remove unused include of init.h Anson Huang
2020-02-22 15:59 ` Guenter Roeck
2020-02-21 2:00 ` [PATCH 3/3] watchdog: imx2_wdt: " Anson Huang
2020-02-22 16:02 ` Guenter Roeck [this message]
2020-02-23 0:16 ` Anson Huang
2020-02-23 14:08 ` Guenter Roeck
2020-02-24 2:54 ` Anson Huang
2020-02-22 15:55 ` [PATCH 1/3] watchdog: imx_sc_wdt: Remove unused includes Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200222160218.GA12740@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox