Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER

H. Nikolaus Schaller
2020-02-17T20:25:28Z

Hi Ladis,

> Am 17.02.2020 um 21:19 schrieb Ladislav Michl <ladis@linux-mips.org>:
>
> Hi Nikolaus,
>
> On Mon, Feb 17, 2020 at 08:33:52PM +0100, H. Nikolaus Schaller wrote:
>> Hi Ladis,
>>
>>> Am 17.02.2020 um 20:07 schrieb Ladislav Michl <ladis@linux-mips.org>:
>>> Linux kernel prints so many lines on bootup and only few of them are
>>> valuable. Lets improve it by printing error value to give a clue
>>> why it failed.
>>
>> Hm. The upstream code does already print the error. This feature is not removed.
>> But it is also printing an error in the EPROBE_DEFER case as well, where it is
>> not needed or not an error.
>
> It seems you missed I'm printing also error _value_.

Indeed.

Well, usually there is no error so adding the error number is not of much
use (except for debugging)... The most likely one seems to be -EPROBE_DEFER.

On the omap5 boards where I have seen the error message being printed they were
EPROBE_DEFER.

So your proposal changes the subject (which has a very small focus).

> The rest of discussion
> would need disassembly and I'll do it once I'll be waiting for yet another
> long run recompile.

:)

BR and thanks,
Nikolaus