From: Mark Brown <broonie@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org,
lgirdwood@gmail.com, thierry.reding@gmail.com, digetx@gmail.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com,
rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com
Subject: Re: Re: [PATCH v3 03/10] ASoC: tegra: add Tegra210 based DMIC driver
Date: Mon, 24 Feb 2020 13:18:26 +0000 [thread overview]
Message-ID: <20200224131826.GI6215@sirena.org.uk> (raw)
In-Reply-To: <f70c7c12-dbc0-a725-f06a-86fab868e7dc@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
On Mon, Feb 24, 2020 at 05:59:33PM +0530, Sameer Pujar wrote:
> On 2/24/2020 5:14 PM, Mark Brown wrote:
> > I don't think so, I'd not expect the individual drivers to be doing
> > anything user visible here - if we know what a digital transformation
> > looks like the framework should be offering anything that's needed to
> > users (and hiding controls that don't have any practical control in a
> > given system).
> Are you suggesting to have some alternate way of users configuring sample
> rates (and other params) and not use mixer control method?
I'm mainly saying the driver shouldn't be doing it directly, it should
be doing something much closer to hwparams for digital formats.
> This is a typical use case we see,
> - [stream-1] Lets say high resolution audio is playing (96kHz, 24-bit,
> stereo)
> - [stream-2] Randomly system notifications of small durations come (48kHz,
> 16-bit, stereo)
> The requirement is, both streams should be mixed and played.
Most systems like this would run the output at a fixed sample rate here
so there'd be no runtime configuration.
> Is there a better way for user to configure custom audio paths?
Fit what you're doing into DPCM. It's not particularly great but it's
what we have at the minute.
This isn't me not understanding your use case, this is me saying that
it would be better to either work like other existing drivers or improve
the framework so that it works better for everyone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-24 13:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 6:34 [PATCH v3 00/10] add ASoC components for AHUB Sameer Pujar
2020-02-20 6:34 ` [PATCH v3 01/10] dt-bindings: sound: tegra: add DT binding " Sameer Pujar
2020-02-21 12:39 ` Mark Brown
2020-02-26 16:02 ` Rob Herring
2020-02-20 6:34 ` [PATCH v3 02/10] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-02-20 14:30 ` Jon Hunter
2020-02-21 5:27 ` Dmitry Osipenko
2020-02-20 6:34 ` [PATCH v3 03/10] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-02-20 14:36 ` Jon Hunter
2020-02-21 5:53 ` Dmitry Osipenko
2020-02-21 13:00 ` Mark Brown
2020-02-21 14:31 ` Jon Hunter
2020-02-21 16:55 ` Mark Brown
2020-02-24 11:28 ` Jon Hunter
2020-02-24 11:44 ` Mark Brown
2020-02-24 12:29 ` Sameer Pujar
2020-02-24 13:18 ` Mark Brown [this message]
2020-02-28 7:30 ` Viswanath L
2020-02-20 6:34 ` [PATCH v3 04/10] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-02-20 14:45 ` Jon Hunter
2020-02-21 13:21 ` Mark Brown
2020-02-20 6:34 ` [PATCH v3 05/10] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-02-20 6:51 ` Randy Dunlap
2020-02-20 15:08 ` Jon Hunter
2020-02-21 13:38 ` Mark Brown
2020-02-20 6:34 ` [PATCH v3 06/10] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-02-20 6:53 ` Randy Dunlap
2020-02-20 15:10 ` Jon Hunter
2020-02-20 6:34 ` [PATCH v3 07/10] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-02-20 6:55 ` Randy Dunlap
2020-02-20 15:16 ` Jon Hunter
2020-02-21 6:08 ` Dmitry Osipenko
2020-02-20 6:34 ` [PATCH v3 08/10] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-02-20 14:49 ` Jon Hunter
2020-02-20 6:34 ` [PATCH v3 09/10] arm64: tegra: enable AHUB modules " Sameer Pujar
2020-02-20 14:52 ` Jon Hunter
2020-02-20 6:34 ` [PATCH v3 10/10] arm64: defconfig: enable AHUB components for Tegra210 and later Sameer Pujar
2020-02-20 14:52 ` Jon Hunter
2020-02-21 5:44 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224131826.GI6215@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=rlokhande@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox