From: Andreas Kemnade <andreas@kemnade.info>
To: Mark Brown <broonie@kernel.org>
Cc: hns@goldelico.com, j.neuschaefer@gmx.net, contact@paulk.fr,
GNUtoo@cyberdimension.org, josua.mayer@jm0.eu,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] regulator: core: fix handling negative voltages e.g. in EPD PMICs
Date: Mon, 24 Feb 2020 19:46:25 +0100 [thread overview]
Message-ID: <20200224194625.20078cf2@kemnade.info> (raw)
In-Reply-To: <20200224120512.GG6215@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
Hi,
On Mon, 24 Feb 2020 12:05:12 +0000
Mark Brown <broonie@kernel.org> wrote:
> On Sun, Feb 23, 2020 at 04:35:01PM +0100, Andreas Kemnade wrote:
>
> > An alternative would be to handle voltages as absolute values.
> > There are probably no regulators with support both negative
> > and positive output.
>
> This is what'd be needed, your approach here is a bit of a hack and
> leaves some values unrepresentable if they overlap with errnos which
> obviously has issues if someone has a need for those values. Ground is
> to a large extent somewhat arbatrary anyway and some systems do just
> redefine it as part of their normal operation (eg, VMID based audio
> systems) so this wouldn't be a huge departure.
Thanks for clarification, outputs from 0mV to -4mV would not be be
representable. I am now converting stuff to think positive ;-) That
is good to decide early before pushing my huge pile of things needed
for EPD support on top of mainline somewhere.
Parallel I am evaluating upstreaming of the tps65181 driver which
probably ends up in a rewrite...
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-02-24 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 15:35 [PATCH RFC] regulator: core: fix handling negative voltages e.g. in EPD PMICs Andreas Kemnade
2020-02-24 12:05 ` Mark Brown
2020-02-24 12:22 ` H. Nikolaus Schaller
2020-02-24 12:31 ` Mark Brown
2020-02-24 18:46 ` Andreas Kemnade [this message]
2020-02-24 15:21 ` Denis 'GNUtoo' Carikli
2020-02-24 17:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224194625.20078cf2@kemnade.info \
--to=andreas@kemnade.info \
--cc=GNUtoo@cyberdimension.org \
--cc=broonie@kernel.org \
--cc=contact@paulk.fr \
--cc=hns@goldelico.com \
--cc=j.neuschaefer@gmx.net \
--cc=josua.mayer@jm0.eu \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox