From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F3EC38BFA for ; Mon, 24 Feb 2020 21:32:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16C112084E for ; Mon, 24 Feb 2020 21:32:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="n2R+f4R/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728068AbgBXVc2 (ORCPT ); Mon, 24 Feb 2020 16:32:28 -0500 Received: from merlin.infradead.org ([205.233.59.134]:42534 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726980AbgBXVc1 (ORCPT ); Mon, 24 Feb 2020 16:32:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=91LwxLWvdfJmKpIkvnbgVBtKYjb/D3h4IRfL3vb9smw=; b=n2R+f4R/VQE8sdI8xxw08ZSM4s 2VktBF/WEtXYZWmIIdQvP5UhysH3fmG732lFdKX3UuW3KvVZxDlQrLYAgwAFu2KOyit6nHfP+FGnT 7Md1GgBE3FOnkz1ZuCi5cRgYkO3oRst5y4CJhT5TfCZfmXrg0xmNTm+jRKnAvlSTKMj3cMGERS3bX Pv1uvCRdzjcnXlD2ECh65C6U91CA/ZbfyBabEGIqt0gpMQNKqKy9S0AudEZtcF3tW7erIgWu267bs C4QD66T+Ig/yXxg891EnEeRR73Z8SX6hdCHRoWC3qLyTKtlssSdZsU09s274E7dP4NCl7uGM0v/NI FbiOoWoQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6LKP-0000dO-30; Mon, 24 Feb 2020 21:31:49 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 81F1C980E37; Mon, 24 Feb 2020 22:31:39 +0100 (CET) Date: Mon, 24 Feb 2020 22:31:39 +0100 From: Peter Zijlstra To: Steven Rostedt Cc: Andy Lutomirski , LKML , linux-arch , Ingo Molnar , Joel Fernandes , Greg KH , gustavo@embeddedor.com, Thomas Gleixner , paulmck@kernel.org, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Tony Luck , Frederic Weisbecker , Dan Carpenter , Masami Hiramatsu Subject: Re: [PATCH v4 05/27] x86: Replace ist_enter() with nmi_enter() Message-ID: <20200224213139.GO11457@worktop.programming.kicks-ass.net> References: <20200221133416.777099322@infradead.org> <20200221134215.328642621@infradead.org> <20200221202246.GA14897@hirez.programming.kicks-ass.net> <20200224104346.GJ14946@hirez.programming.kicks-ass.net> <20200224112708.4f307ba3@gandalf.local.home> <20200224163409.GJ18400@hirez.programming.kicks-ass.net> <20200224114754.0fb798c1@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224114754.0fb798c1@gandalf.local.home> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 11:47:54AM -0500, Steven Rostedt wrote: > On Mon, 24 Feb 2020 17:34:09 +0100 > Peter Zijlstra wrote: > > > Looking at nmi_enter(), that leaves trace_hardirq_enter(), since we know > > we marked rcu_nmi_enter() as NOKPROBES, per the patches elsewhere in > > this series. > > Maybe this was addressed already in the series, but I'm just looking at > Linus's master branch we have: > > #define nmi_enter() \ > do { \ > arch_nmi_enter(); \ > printk_nmi_enter(); \ > lockdep_off(); \ > ftrace_nmi_enter(); \ > BUG_ON(in_nmi()); \ > preempt_count_add(NMI_OFFSET + HARDIRQ_OFFSET); \ > rcu_nmi_enter(); \ > trace_hardirq_enter(); \ > } while (0) > > > Just want to confirm that printk_nmi_enter(), lockdep_off(), > and ftrace_nmi_enter() are all marked fully with NOKPROBE. *sigh*, right you are, I only looked at notrace, not nokprobe. In particular the ftrace one is a bit off a mess, let me sort through that.