From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A1D7C4BA0B for ; Wed, 26 Feb 2020 05:47:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 308D8206E2 for ; Wed, 26 Feb 2020 05:47:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GG34xp+s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726900AbgBZFri (ORCPT ); Wed, 26 Feb 2020 00:47:38 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:35299 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbgBZFrh (ORCPT ); Wed, 26 Feb 2020 00:47:37 -0500 Received: by mail-pf1-f196.google.com with SMTP id i19so879443pfa.2 for ; Tue, 25 Feb 2020 21:47:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mptYcm23xnKvc9dgW9yrQXDjYvemyNk9HOkOd35jyu0=; b=GG34xp+sWUcxvfNAwlpF2R/g3l9vUFYZh5jCdgnO1j5GJFdkhJ8n8xO7GULcjNoKEp QxNEXfAL5rOSEhshwXbzHaFc2qzrx7b9Gwp0mbHXHVCjBSiWC1UNiT8q6G9dTjhshfOG ocqn8ZnQkBG8WTcYA/SDlaoUa0SHMRrTDEjZ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mptYcm23xnKvc9dgW9yrQXDjYvemyNk9HOkOd35jyu0=; b=K+O6cT1pUn1CJPmJk05JLCusoqAA+ToNhs88/mipsXLdFetLPhbCE6yojdAYiR+HuM 5DYGzJUNbeYWP8QfkNmylxwQ+GZX0vbnjLOCHnCWWIFQk2HNMTL0JcioPCVg48wUv900 3UYHCLV9ft9chtFXdcaeJxnxNzIbZSmHm1Ra4ls2V3vqJEEZNdHcqIcF24QNZfJyufTa Kc4k6xf7pA7uho6/lwRFiM5ZPIkSosK+jerJRZhjSexBt6nHfsv9cQJRGJKmy/ZDr7wY Af+3cL93xtMXZEnkPijPu5R2acAqzMVv9sf94riFbQh3m/Mt48AhWHtD1cdd+yS1s4Tw xaew== X-Gm-Message-State: APjAAAWy6NwX9rqGXTofm+TRE4kKdwtXZdH6ZnmCmNaZq0BNc56bIipB poFoFfnqIF5yTfu5+G+AvVdCAw== X-Google-Smtp-Source: APXvYqw9Hah4jb9PwhTerdiDuprKFah9gRyTjuGaX0a1kpnDdbyuJ+/fWg81/jtilUouDk0Nrkg0Fg== X-Received: by 2002:aa7:85d8:: with SMTP id z24mr2682501pfn.202.1582696054765; Tue, 25 Feb 2020 21:47:34 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o22sm898504pgj.58.2020.02.25.21.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 21:47:33 -0800 (PST) Date: Tue, 25 Feb 2020 21:47:32 -0800 From: Kees Cook To: Mark Brown Cc: Catalin Marinas , Will Deacon , Alexander Viro , Paul Elliott , Peter Zijlstra , Yu-cheng Yu , Amit Kachhap , Vincenzo Frascino , Marc Zyngier , Eugene Syromiatnikov , Szabolcs Nagy , "H . J . Lu " , Andrew Jones , Arnd Bergmann , Jann Horn , Richard Henderson , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Thomas Gleixner , Florian Weimer , Sudakshina Das , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, Dave Martin Subject: Re: [PATCH v6 05/11] arm64: elf: Enable BTI at exec based on ELF program properties Message-ID: <202002252146.7230873E@keescook> References: <20200212192906.53366-1-broonie@kernel.org> <20200212192906.53366-6-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212192906.53366-6-broonie@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12, 2020 at 07:29:00PM +0000, Mark Brown wrote: > diff --git a/include/linux/elf.h b/include/linux/elf.h > index 1b6e8955c597..5d5b0321da0b 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -63,7 +63,11 @@ extern int elf_coredump_extra_notes_size(void); > extern int elf_coredump_extra_notes_write(struct coredump_params *cprm); > #endif > > -/* NT_GNU_PROPERTY_TYPE_0 header */ > +/* > + * NT_GNU_PROPERTY_TYPE_0 header: > + * Keep this internal until/unless there is an agreed UAPI definition. > + * pr_type values (GNU_PROPERTY_*) are public and defined in the UAPI header. > + */ > struct gnu_property { > u32 pr_type; > u32 pr_datasz; I think this hunk should be in patch 1. -- Kees Cook