Re: [patch 07/24] x86/traps: Prepare for using DEFINE_IDTENTRY

Thomas Gleixner
2020-02-28T14:18:19Z

Alexandre Chartre <alexandre.chartre@oracle.com> writes:
> On 2/25/20 11:16 PM, Thomas Gleixner wrote:
>> Prepare for using IDTENTRY to define the C exception/trap entry points. It
>> would be possible to glue this into the existing macro maze, but it's
>> simpler and better to read at the end to just make them distinct. Provide
>> a trivial inline helper to read the trap address.
>>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> ---
>> arch/x86/kernel/traps.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> --- a/arch/x86/kernel/traps.c
>> +++ b/arch/x86/kernel/traps.c
>> @@ -274,6 +274,11 @@ static void do_error_trap(struct pt_regs
>> }
>> }
>>
>> +static inline void __user *error_get_trap_addr(struct pt_regs *regs)
>> +{
>> + return (void __user *)uprobe_get_trap_addr(regs);
>> +}
>> +
>> #define IP ((void __user *)uprobe_get_trap_addr(regs))
>
> And you will eventually get rid of this IP macro, right?

The whole macro maze will be gone at the end.