[PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

[PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

[Jolly Shah]

From: Tejas Patel <tejas.patel@xilinx.com>

Make zynqmp_firmware driver as optional to disable it, if user don't
want to use default zynqmp firmware interface.

Signed-off-by: Tejas Patel <tejas.patel@xilinx.com>
Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
---
 arch/arm64/Kconfig.platforms    | 1 -
 drivers/firmware/xilinx/Kconfig | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index b2b504e..563c93d 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -301,7 +301,6 @@ config ARCH_ZX
 
 config ARCH_ZYNQMP
 	bool "Xilinx ZynqMP Family"
-	select ZYNQMP_FIRMWARE
 	help
 	  This enables support for Xilinx ZynqMP Family
 
diff --git a/drivers/firmware/xilinx/Kconfig b/drivers/firmware/xilinx/Kconfig
index bd33bbf..9a9bd19 100644
--- a/drivers/firmware/xilinx/Kconfig
+++ b/drivers/firmware/xilinx/Kconfig
@@ -6,6 +6,8 @@ menu "Zynq MPSoC Firmware Drivers"
 
 config ZYNQMP_FIRMWARE
 	bool "Enable Xilinx Zynq MPSoC firmware interface"
+	depends on ARCH_ZYNQMP
+	default y if ARCH_ZYNQMP
 	select MFD_CORE
 	help
 	  Firmware interface driver is used by different
-- 
2.7.4

Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

[Sudeep Holla]

On Tue, Feb 25, 2020 at 04:04:20PM -0800, Jolly Shah wrote:
> From: Tejas Patel <tejas.patel@xilinx.com>
>
> Make zynqmp_firmware driver as optional to disable it, if user don't
> want to use default zynqmp firmware interface.
>

This patch on it own is simple and looks fine. However I expect the
single binary to work with and without this option on the same platform.
If zynqmp_firmware is not critical, the system should continue to work
fine either way. The zynqmp_firmware driver should gracefully exit with
error(if any).

--
Regards,
Sudeep

Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

[Jolly Shah]

Hi Sudeep,

 > ------Original Message------
 > From: Sudeep.holla@arm.com <sudeep.holla@arm.com>
 > Sent:  Wednesday, February 26, 2020 3:46AM
 > To: Jolly Shah <jolly.shah@xilinx.com>
 > Cc: Ard.biesheuvel@linaro.org <ard.biesheuvel@linaro.org>, 
Mingo@kernel.org <mingo@kernel.org>, 'Greg Kh' 
<gregkh@linuxfoundation.org>, Matt@codeblueprint.co.uk 
<matt@codeblueprint.co.uk>, Hkallweit1@gmail.com <hkallweit1@gmail.com>, 
Keescook@chromium.org <keescook@chromium.org>, Dmitry.torokhov@gmail.com 
<dmitry.torokhov@gmail.com>, Michal Simek <michal.simek@xilinx.com>, 
Rajan Vaja <rajanv@xilinx.com>, Linux-arm-kernel@lists.infradead.org 
<linux-arm-kernel@lists.infradead.org>, Linux-kernel@vger.kernel.org 
<linux-kernel@vger.kernel.org>, Tejas Patel <tejas.patel@xilinx.com>, 
Sudeep.holla@arm.com <sudeep.holla@arm.com>
 > Subject: Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver 
optional
 >
> On Tue, Feb 25, 2020 at 04:04:20PM -0800, Jolly Shah wrote:
>> From: Tejas Patel <tejas.patel@xilinx.com>
>>
>> Make zynqmp_firmware driver as optional to disable it, if user don't
>> want to use default zynqmp firmware interface.
>>
> 
> This patch on it own is simple and looks fine. However I expect the
> single binary to work with and without this option on the same platform.
> If zynqmp_firmware is not critical, the system should continue to work
> fine either way. The zynqmp_firmware driver should gracefully exit with
> error(if any).
> 

Sure. Will address it in next version.

Thanks,
Jolly Shah


> --
> Regards,
> Sudeep
> 

Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

[Michal Simek]

On 26. 02. 20 1:04, Jolly Shah wrote:
> From: Tejas Patel <tejas.patel@xilinx.com>
> 
> Make zynqmp_firmware driver as optional to disable it, if user don't
> want to use default zynqmp firmware interface.
> 
> Signed-off-by: Tejas Patel <tejas.patel@xilinx.com>
> Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
> ---
>  arch/arm64/Kconfig.platforms    | 1 -
>  drivers/firmware/xilinx/Kconfig | 2 ++
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index b2b504e..563c93d 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -301,7 +301,6 @@ config ARCH_ZX
>  
>  config ARCH_ZYNQMP
>  	bool "Xilinx ZynqMP Family"
> -	select ZYNQMP_FIRMWARE
>  	help
>  	  This enables support for Xilinx ZynqMP Family
>  
> diff --git a/drivers/firmware/xilinx/Kconfig b/drivers/firmware/xilinx/Kconfig
> index bd33bbf..9a9bd19 100644
> --- a/drivers/firmware/xilinx/Kconfig
> +++ b/drivers/firmware/xilinx/Kconfig
> @@ -6,6 +6,8 @@ menu "Zynq MPSoC Firmware Drivers"
>  
>  config ZYNQMP_FIRMWARE
>  	bool "Enable Xilinx Zynq MPSoC firmware interface"
> +	depends on ARCH_ZYNQMP
> +	default y if ARCH_ZYNQMP
>  	select MFD_CORE
>  	help
>  	  Firmware interface driver is used by different
> 

Applied but with arm64: zynqmp: Prefixes.

Thanks,
Michal